From owner-cvs-all@FreeBSD.ORG Tue Mar 6 23:12:30 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9630D16A400; Tue, 6 Mar 2007 23:12:30 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.freebsd.org (Postfix) with ESMTP id 2FB2113C4A5; Tue, 6 Mar 2007 23:12:30 +0000 (UTC) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id B042F133BDB; Wed, 7 Mar 2007 09:42:28 +1030 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id A37CA1A9CBD; Wed, 7 Mar 2007 09:42:28 +1030 (CST) Date: Wed, 7 Mar 2007 09:42:28 +1030 From: Greg 'groggy' Lehey To: Ruslan Ermilov Message-ID: <20070306231228.GC68567@wantadilla.lemis.com> References: <200703061454.l26Esj7D043245@repoman.freebsd.org> <45EDA7E2.4040300@freebsd.org> <20070306204307.GD43608@rambler-co.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hYooF8G/hrfVAmum" Content-Disposition: inline In-Reply-To: <20070306204307.GD43608@rambler-co.ru> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib url.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2007 23:12:30 -0000 --hYooF8G/hrfVAmum Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 6 March 2007 at 23:43:07 +0300, Ruslan Ermilov wrote: > On Tue, Mar 06, 2007 at 09:41:54AM -0800, Tim Kientzle wrote: >> Ruslan Ermilov wrote: >>> Modified files: >>> usr.sbin/pkg_install/lib url.c >>> Log: >>> Invoke tar(1) with the -p option when installing a package >>> from an URL (i.e., do it the same way as when installing >>> from a file). This fixes the lossage of the setuid bits. >>> It wasn't a problem before because GNU tar(1) implied the >>> -p option for root, but BSD tar(1) doesn't do that. >> >> Hmmm... This might actually be considered a bsdtar bug. >> I'll look into it. > > That behavior of BSD tar(1) surprised me, to be honest. I'm very much in favour of keeping the discrepancies (and surprises!) between gnutar and bsdtar to a minimum. Should we remove this one? Greg -- See complete headers for address and phone numbers. --hYooF8G/hrfVAmum Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFF7fVcIubykFB6QiMRAoAZAKCFp+gIEtsBBQhWkzMWnPfEFD3UWQCeJYPu /vrI0Nhg4A3djV+8ps6HWdE= =VoLw -----END PGP SIGNATURE----- --hYooF8G/hrfVAmum--