From owner-svn-src-projects@FreeBSD.ORG Sat May 14 23:40:38 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78C25106566B; Sat, 14 May 2011 23:40:38 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id 21ACE8FC13; Sat, 14 May 2011 23:40:37 +0000 (UTC) Received: by yxl31 with SMTP id 31so1524216yxl.13 for ; Sat, 14 May 2011 16:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=sxEip4rRqZMOIBmKlKjwlHlyHeM78dsTZBViM7QSwD8=; b=p98meL+e+zttPyMn9uYyhPkH7fpLSRjxj4SnjXf1OEYPLEBdS3OoEUFYPFZQ34ClgL Fvhn9j7Bovi0OCTaSXStYEBLv0q1ZVLMBsb2H5QWMxzgiIqJWN3apvldfrRQn5MmOovX zD3/zGWlFenELXo87eXURK9PhqFNbB/+jxVds= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=MtWWhAHLfomOufSQQnrkXdDB4pgAjXKqrPArbNuAWFTLY1xB5aRXhmixmzbCKLqabE apk0kIYTYgKPznlZUaEE4CThLOm1BCRW7oBiiYwbhCYSLk1auYHgB3qZ3bMRQQSz1mVH /kXDnJXGQOsVJa4qM5k19LWkXSG6seB7Ou0PI= MIME-Version: 1.0 Received: by 10.236.192.230 with SMTP id i66mr2876408yhn.482.1305416435899; Sat, 14 May 2011 16:40:35 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.103.130 with HTTP; Sat, 14 May 2011 16:40:35 -0700 (PDT) In-Reply-To: <20110514233028.GF92688@alchemy.franken.de> References: <201105131521.p4DFLVKs074711@svn.freebsd.org> <20110514233028.GF92688@alchemy.franken.de> Date: Sun, 15 May 2011 01:40:35 +0200 X-Google-Sender-Auth: CT71wIxIqRbuc3qQUGQPnFdr1E4 Message-ID: From: Attilio Rao To: Marius Strobl Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221842 - projects/largeSMP/sys/sparc64/sparc64 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2011 23:40:38 -0000 2011/5/15 Marius Strobl : > On Fri, May 13, 2011 at 05:28:59PM +0200, Attilio Rao wrote: >> 2011/5/13 Marius Strobl : >> > Author: marius >> > Date: Fri May 13 15:21:31 2011 >> > New Revision: 221842 >> > URL: http://svn.freebsd.org/changeset/base/221842 >> > >> > Log: >> > ??When setting up pc_other_cpus for APs based on pc_allcpu clear pc_cpuid >> > ??in the former rather than the latter. >> > ??This gets this branch working on at least Jalapeno-class CPUs. >> > >> > Modified: >> > ??projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c >> > >> > Modified: projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c >> > ============================================================================== >> > --- projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c ??Fri May 13 15:20:57 2011 ?? ?? ?? ??(r221841) >> > +++ projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c ??Fri May 13 15:21:31 2011 ?? ?? ?? ??(r221842) >> > @@ -470,7 +470,7 @@ cpu_mp_bootstrap(struct pcpu *pc) >> > ?? ?? ?? ??smp_cpus++; >> > ?? ?? ?? ??KASSERT(curthread != NULL, ("%s: curthread", __func__)); >> > ?? ?? ?? ??ocpus = all_cpus; >> > - ?? ?? ?? CPU_CLR(curcpu, &all_cpus); >> > + ?? ?? ?? CPU_CLR(curcpu, &ocpus); >> > ?? ?? ?? ??PCPU_SET(other_cpus, ocpus); >> > ?? ?? ?? ??printf("SMP: AP CPU #%d Launched!\n", curcpu); >> > >> > >> >> How idiot can I be? >> I watched that path like 10 times yesterday... >> > > FYI, as of r221932 this branch now works MP on all three classes of > Cheetah, Jalapeno and Spitfire CPUs. While working on this I noticed > that there's a bit of room for improvement in the sparc64 IPI code, > which I'll commit once this branch has been merged into head. Then > I'll also add support for more than 32 CPUs in the MD part, both > of which really are orthogonal to the cpuset_t conversion. Thanks a lot for testing. You may be interested to know (as you are not at BSDCan) che this morning we booted a 128 CPUs amd machines with 8 domains level NUMA. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein