From nobody Wed Aug 3 21:09:01 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LykxW3F7dz4XmPQ; Wed, 3 Aug 2022 21:09:03 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LykxW2jRBz3PhJ; Wed, 3 Aug 2022 21:09:03 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659560943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TkjN1eKHoZUojht66mjygsm64+hpxtrrTnpyuKTPj+s=; b=M39iKr5nneS/k50t3p87KYi/89TY1lAfAvcEVL1wUrwxTtf2Z+VqfJfCBA7OG3LfJ9NYhe 7On8UN1kLV3I/v8MElQ2pn5fmN5CBJ5HUdYrOvH71ltBrJNCQ2kyJ9X+S0uAnHupwg9J7J LlW//RqK5/nGs5J/0d/ZhkCIEcLNIpxuEjefyP2T89Lraaa10/nArhtUTKENU1c9zFeXq6 2kDTxiXb5etETNMLOaxuIGYc12BtgWXnzSIVrg3Swaph23k8vOAQdH59dGBNLxabVd+cG/ Jdy+D4pn5fMMI00StkX0Jdba2RrhqvRenpgFexgOyC301m76ww7Py7lhXIb6Hw== Received: from ltc.des.no (unknown [78.156.1.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LykxW154Kzxlc; Wed, 3 Aug 2022 21:09:03 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.no (Postfix, from userid 1001) id A5596AD417; Wed, 3 Aug 2022 23:09:01 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 36d67475f549 - main - xinstall: fix dounpriv logic, add tests In-Reply-To: <87AA26D1-D894-4779-B965-ECD53C581516@freebsd.org> (Jessica Clarke's message of "Wed, 3 Aug 2022 14:59:15 -0600") References: <202208031904.273J4SuL021844@gitrepo.freebsd.org> <87AA26D1-D894-4779-B965-ECD53C581516@freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (berkeley-unix) Date: Wed, 03 Aug 2022 23:09:01 +0200 Message-ID: <86bkt13uhe.fsf@ltc.des.no> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659560943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TkjN1eKHoZUojht66mjygsm64+hpxtrrTnpyuKTPj+s=; b=P4NNQGxp5RQVbVa+h5rBiNuckWd7htrnNoaVGJr6JkwZzVL3E1rEvC12W6t2Yk7KQpJuRE FvXTWGDC7ahjLPde3en82SvbEstrHDOeIJz7RVZLyFHKXWiix+Tvgma/uxsP7Xjvd1ZhgC skYqqAR3NKN/ipqRw9hECVaXTjenzSj56mFx/2KubKzQhNuY3Gx5AFlCriqeQIJ9/rd2VC mjOSCTM1fkw7vXJyZ7lfVQmYwJEKgmpihNpExEUWLiV6jTtPQnDrwxbGtQopnnfIp09ZgL 0b2Srpe46PubTOvpzuwBwNQnkHWWTZjnGeN8cCtAOVySZ24u56HkE97pWfcd9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659560943; a=rsa-sha256; cv=none; b=pSBvxxpnxqzQgPEXZ91HeeSEhmtAt/Um9d3CIDRcodVIr/Z2Lvg+Ws6mB4EKddnbRY5Pt/ 2GC9IoHusT99uj/TqPdQKal9DPpgbEnCP8JbWwioyfqPMC18Du6cIfwq4xtwPFUhOcMHaA UdxV6kE6cFjlm/Uh7gJ86UMoL8rQF4QDdFRjdTth8E2gA9yLYEB6ocpxtqaTiSx9GBMZB8 x+cPr9r0uUnjejvrSgVbUembEURczjumlasb8pVkn70YM80kSKvdMBDS02g3YDBM8BnIYn ZBvMwgISyUZcbCSrFYOmyn7T9LxT63nPu+fbK+2Wihi3hBA7iDtUMtLQ3XRnsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Jessica Clarke writes: > This is quite a poor commit message. What was wrong with it? Especially > when the diff is cluttered with reformatting. I cannot obviously see > any behavioural changes, just some changes from & to && that I don=E2=80= =99t > believe technically matter, even if poor practice and not intended. Take a closer look here: >> - if (!dounpriv &=20 >> - (gid !=3D (gid_t)-1 && gid !=3D to_sb.st_gid) || >> - (uid !=3D (uid_t)-1 && uid !=3D to_sb.st_uid)) >> + if (!dounpriv && ((gid !=3D (gid_t)-1 && gid !=3D to_sb.st_gid) || >> + (uid !=3D (uid_t)-1 && uid !=3D to_sb.st_uid))) { The intended logic is: if not unpriv and (need to set gid or need to set uid) The actual logic is: if (not unpriv and need to set gid) or need to set uid Luckily it had no practical effect because uid and gid are always -1 when dounpriv is non-zero. I pulled the gid line up to match the formatting of the previous conditional, ten or so lines back. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org