From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 18 02:00:11 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D6A9106566C for ; Wed, 18 Nov 2009 02:00:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C5EFD8FC17 for ; Wed, 18 Nov 2009 02:00:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAI202MS061843 for ; Wed, 18 Nov 2009 02:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nAI202lw061842; Wed, 18 Nov 2009 02:00:02 GMT (envelope-from gnats) Resent-Date: Wed, 18 Nov 2009 02:00:02 GMT Resent-Message-Id: <200911180200.nAI202lw061842@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ben Kelly Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B8BC106566B for ; Wed, 18 Nov 2009 01:54:50 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 8A4A88FC18 for ; Wed, 18 Nov 2009 01:54:50 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nAI1sob3045505 for ; Wed, 18 Nov 2009 01:54:50 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nAI1so03045487; Wed, 18 Nov 2009 01:54:50 GMT (envelope-from nobody) Message-Id: <200911180154.nAI1so03045487@www.freebsd.org> Date: Wed, 18 Nov 2009 01:54:50 GMT From: Ben Kelly To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: conf/140650: WITHOUT_MODULES cannot be used from kernel config with makeoptions X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2009 02:00:11 -0000 >Number: 140650 >Category: conf >Synopsis: WITHOUT_MODULES cannot be used from kernel config with makeoptions >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Nov 18 02:00:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Ben Kelly >Release: CURRENT >Organization: >Environment: FreeBSD ianto.in.wanderview.com 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r254M: Fri Nov 13 23:26:25 UTC 2009 root@ianto.in.wanderview.com:/usr/obj/usr/src/sys/SERVER i386 >Description: Currently you can only specify WITHOUT_MODULES in /etc/make.conf. This is unintuitive since the related variable MODULES_OVERRIDE is often used from kernel config files. The attached patch fixes this problem for me. >How-To-Repeat: >Fix: Index: sys/conf/kern.pre.mk =================================================================== --- sys/conf/kern.pre.mk (revision 254) +++ sys/conf/kern.pre.mk (working copy) @@ -163,6 +163,9 @@ .if defined(MODULES_OVERRIDE) MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}" .endif +.if defined(WITHOUT_MODULES) +MKMODULESENV+= WITHOUT_MODULES="${WITHOUT_MODULES}" +.endif .if defined(DEBUG) MKMODULESENV+= DEBUG_FLAGS="${DEBUG}" .endif >Release-Note: >Audit-Trail: >Unformatted: