From owner-svn-src-head@freebsd.org  Thu Jul 26 14:22:35 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF7161050BFD;
 Thu, 26 Jul 2018 14:22:35 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 317649185E;
 Thu, 26 Jul 2018 14:22:35 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w6QEMWeW046071;
 Thu, 26 Jul 2018 07:22:32 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w6QEMUwH046070;
 Thu, 26 Jul 2018 07:22:30 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r336737 - head/usr.bin/top
In-Reply-To: <201807261353.w6QDrMRI036171@repo.freebsd.org>
To: Daichi GOTO <daichi@freebsd.org>
Date: Thu, 26 Jul 2018 07:22:30 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 14:22:35 -0000

> Author: daichi
> Date: Thu Jul 26 13:53:22 2018
> New Revision: 336737
> URL: https://svnweb.freebsd.org/changeset/base/336737
> 
> Log:
>   top(1): forgot in r336160

It is helpful to say what was forgot in the commit message as when
you are reading a svn log output you do not have the diff to show
you what it was that has been forgot.

Better message would of been:
   Remove utf8strvisx prototype, forgotten in r336160


Thanks,
Rod
>   
>   Approved by:	gnn (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D16452
> 
> Modified:
>   head/usr.bin/top/utils.h
> 
> Modified: head/usr.bin/top/utils.h
> ==============================================================================
> --- head/usr.bin/top/utils.h	Thu Jul 26 13:33:10 2018	(r336736)
> +++ head/usr.bin/top/utils.h	Thu Jul 26 13:53:22 2018	(r336737)
> @@ -22,5 +22,4 @@ const char *format_time(long);
>  char *format_k(int64_t);
>  int string_index(const char *string, const char * const *array);
>  int find_pid(pid_t pid);
> -int utf8strvisx(char *, const char *, size_t);
>  
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org