From owner-freebsd-arch@FreeBSD.ORG Wed Feb 24 15:50:51 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05AE3106566B; Wed, 24 Feb 2010 15:50:51 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f185.google.com (mail-iw0-f185.google.com [209.85.223.185]) by mx1.freebsd.org (Postfix) with ESMTP id 9EE348FC19; Wed, 24 Feb 2010 15:50:50 +0000 (UTC) Received: by iwn15 with SMTP id 15so4223694iwn.7 for ; Wed, 24 Feb 2010 07:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=oTvTtoq+sPmStOqN2jYAHxlUohjbCrngHbLQgBR8dLg=; b=uAPdgxQYRLo5zzKlm23INm451BNB4/k58dEioK/W+ehMFdqQAkvHd6ET1iyrOt2T4y ukgr53knWhsAV3CYjPVUiNwkMCXlgEKjag4KwM1BEhcw2xAuMR794WmEXbgQ3o9uG5m0 F/ZUfNikZ2aTat9Vjbi9gx4y20CDEBTNI/bIg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=tJjrJHhbi2Rvmu6osbdyC5KXR8MZX01enAl6xzsf2NOzHtho28sJWJfE+cXbyFNHEZ mMCK4wQCbuje4xVOfJoASh1mshh7lAw+7Y5dpsrNBhgPJMnFY6JiEmWd6wbDLNZD593N 0yFPG/J08fkNVIh9wXH3PEJNziUUxz6lmDoRg= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.148.205 with SMTP id q13mr2625ibv.47.1267026649923; Wed, 24 Feb 2010 07:50:49 -0800 (PST) In-Reply-To: <201002241041.56118.jhb@freebsd.org> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> <3bbf2fe11002240718x5182aa93w5a00c657a0fba5f6@mail.gmail.com> <201002241041.56118.jhb@freebsd.org> Date: Wed, 24 Feb 2010 16:50:49 +0100 X-Google-Sender-Auth: 5e4c36da3a35657b Message-ID: <3bbf2fe11002240750r69779948icc6d242fce26abc8@mail.gmail.com> From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Kostik Belousov , FreeBSD Arch , Ed Maste , freebsd-arch@freebsd.org Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2010 15:50:51 -0000 2010/2/24 John Baldwin : > On Wednesday 24 February 2010 10:18:34 am Attilio Rao wrote: >> 2010/2/16 Kostik Belousov : >> > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> >> The following patch: >> >> http://www.freebsd.org/~attilio/x86.diff >> >> >> >> starts the effort for having a shared sub-tree between amd64 and ia32= . >> >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> >> and what my customer was more interested in (isa/*) in order to >> >> kick-off the effort and, in the future, move gradually the code there= . >> >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sur= e >> >> more can be achieved easilly. >> >> There are few things to discuss. One, that I had not necessity to dig >> >> about still, is about how to organize headers (include/). Maybe some >> >> replication ala pc98 may be good. >> >> >> >> The patch is big but it is mostly added and removed files (look at th= e >> >> files.X in order to understand better how files movements happened). >> >> >> >> Hope to see comments and reviews. >> > >> > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) >> > operation now, without a review, and post a diff that should be applie= d >> > to x86/ directory, as well as to build glue. >> >> I think that this patch juices out all the relevant part without noise: >> http://www.freebsd.org/~attilio/x86-2.diff > > I think this looks good. =C2=A0We should likely be unifying the approach = to > suspend/resume for timers across i386 and amd64 btw. =C2=A0pmtimer should= be > available for amd64 as well for example. =C2=A0I'm also not sure if addin= g a resume > method for atrtc means that pmtimer needs to change to not frob the RTC i= n its > suspend and resume methods now as well. Yes, I would do this (and other simple, already compelling, unifications, like the e/rflags one) into further passes. In this case, probabilly, more mealpieces we do the better it is, IMHO. Attilio --=20 Peace can only be achieved by understanding - A. Einstein