From owner-svn-src-head@freebsd.org Thu May 18 18:42:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30685D71979; Thu, 18 May 2017 18:42:56 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 03D7D128A; Thu, 18 May 2017 18:42:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x230.google.com with SMTP id o12so34405024iod.3; Thu, 18 May 2017 11:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=OpcCCWc/cLdJxbsrEMZR7iAuCNjcq596QXkG5b12/qM=; b=Mr/HFHIrKi58Z8z+Ubdr3l0LyhSQBcnTdHdjdR3j4Xh9yIahWGR4OZVVFM39DV0qgT r/IW6q2HcLk0TVw+e6PMT02Yc+lGJ7iyJ8ubinj2Y59BPcpYgN1AUuMxQ7oWR4Zf+n5E +w6AbdpIvS0JhMDqxYiJfps/XbMaSABnFVxdhY8CDBJ2UXJ8N9aGZWoQOR1mY38xBkN9 GCA0Ew/A+LrrKzeFSjQMyhoi8hYGCQHynpdv+T5e91FlTs8RnhOMDBV11W2QxFSGRXTs qcOTEx0sUerdPAoLndMZOZCikb9FFB/V2VVyXAemrVTuGoYXwQ3JPsLxfWf7ZEkJGlOJ 72aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=OpcCCWc/cLdJxbsrEMZR7iAuCNjcq596QXkG5b12/qM=; b=sK2fyQNCETI1Pk/wj+vRZEPBgx59xWr/BRPHu9EDmqY1DiFX5urbAKpbkPxYZa4/70 K9M43Dt573v/nmPUEQy1uQKoDKJta3lcYlgkP/TiLCFlMgzOIuM+V2pj3JDBKv42siDS TVFGkK0FNE8b6/vsK9QJxyeuBvDEWuoPXsYdUpnVzdCzPhWSXEsZqIgH23OtPudlth0V l62jgz24Ll6T/kQM1V1vNrqx9dF/5AWloBm8nQ9JiRM8jxoiBUhzz7BJuxqOAqIYJtjM +6YkRlgci4RKDvVSdawYPI01Spy5fwglBZUou/HqknFx30lc77pchNfJxPLG38ui2KjW xBUA== X-Gm-Message-State: AODbwcBV299dVkyw7FmvRxmCP5vuM+XKzHdrYljKKcLwzNj/RXcPJV0c WDibCS/rxZJapIkRDG66CyTKnzh9Bd3SvcA= X-Received: by 10.107.1.70 with SMTP id 67mr5932569iob.159.1495132975162; Thu, 18 May 2017 11:42:55 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.169.201 with HTTP; Thu, 18 May 2017 11:42:34 -0700 (PDT) In-Reply-To: <201705181755.v4IHtXKi050359@repo.freebsd.org> References: <201705181755.v4IHtXKi050359@repo.freebsd.org> From: Ed Maste Date: Thu, 18 May 2017 14:42:34 -0400 X-Google-Sender-Auth: pBN94yErrIBVw6UVbB4imPimgVc Message-ID: Subject: Re: svn commit: r318474 - head/usr.sbin/makefs To: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 18:42:56 -0000 On 18 May 2017 at 13:55, Ed Maste wrote: > Author: emaste > Date: Thu May 18 17:55:33 2017 > New Revision: 318474 > URL: https://svnweb.freebsd.org/changeset/base/318474 > > Log: > makefs: drop WARNS back to 2 > > GCC warns about additional signed comparision issues compared to Clang. > Drop WARNS for now until the underlying issue is fixed. FYI the GCC warning came from the same blksize macro, but from the conditional expression this time. #define blksize(fs, ip, lbn) \ (((lbn) >= UFS_NDADDR || (ip)->i_size >= \ (uint64_t)smalllblktosize(fs, (lbn) + 1)) \ ? (fs)->fs_bsize \ : (fragroundup(fs, blkoff(fs, (ip)->i_size)))) (fs)->fs_bsize is a signed int, while fragroundup is unsigned (from i_size). > > Modified: > head/usr.sbin/makefs/Makefile > > Modified: head/usr.sbin/makefs/Makefile > ============================================================================== > --- head/usr.sbin/makefs/Makefile Thu May 18 17:44:45 2017 (r318473) > +++ head/usr.sbin/makefs/Makefile Thu May 18 17:55:33 2017 (r318474) > @@ -14,7 +14,7 @@ SRCS= cd9660.c ffs.c \ > walk.c > MAN= makefs.8 > > -WARNS?= 3 > +WARNS?= 2 > > .include "${SRCDIR}/cd9660/Makefile.inc" > .include "${SRCDIR}/ffs/Makefile.inc" >