From owner-freebsd-current@freebsd.org Tue May 10 06:31:50 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E577B35574 for ; Tue, 10 May 2016 06:31:50 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id EC4781E7B for ; Tue, 10 May 2016 06:31:49 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: by mailman.ysv.freebsd.org (Postfix) id EB8A0B35573; Tue, 10 May 2016 06:31:49 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8E29B35572 for ; Tue, 10 May 2016 06:31:49 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A32201E79; Tue, 10 May 2016 06:31:49 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.85) with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (envelope-from ) id <1b01Ct-001qxM-Jw>; Tue, 10 May 2016 08:31:47 +0200 Received: from p578a69f9.dip0.t-ipconnect.de ([87.138.105.249] helo=freyja.zeit4.iv.bundesimmobilien.de) by inpost2.zedat.fu-berlin.de (Exim 4.85) with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (envelope-from ) id <1b01Cs-003vLr-M0>; Tue, 10 May 2016 08:31:47 +0200 Date: Tue, 10 May 2016 08:31:46 +0200 From: "O. Hartmann" To: Glen Barber Cc: current@FreeBSD.org Subject: Re: HEADS-UP: installworld on r299292 through r299317 will replace master.passwd, passwd, and group files Message-ID: <20160510083146.7733899e@freyja.zeit4.iv.bundesimmobilien.de> In-Reply-To: <20160510062436.GB47527@FreeBSD.org> References: <20160510055341.GA47527@FreeBSD.org> <20160510081844.54f1cb28@freyja.zeit4.iv.bundesimmobilien.de> <20160510062436.GB47527@FreeBSD.org> Organization: FU Berlin X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originating-IP: 87.138.105.249 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 06:31:50 -0000 On Tue, 10 May 2016 06:24:36 +0000 Glen Barber wrote: > On Tue, May 10, 2016 at 08:18:44AM +0200, O. Hartmann wrote: > > On Tue, 10 May 2016 05:53:41 +0000 > > Glen Barber wrote: > > > > > Thanks to O. Hartmann promptly reporting this, it was discovered that > > > 'installworld' on revisions r299292-r299317 will silently replace > > > /etc/passwd, /etc/master.passwd, and /etc/group with the defaults. It > > > is possible there are other files affected. One file I can think of > > > off-hand is /etc/mail/aliases, but in my development system, did not > > > have local changes to this, so cannot 100% confirm. > > > > > > Please avoid this range of revisions. > > > > > > I am very sorry this went unnoticed before this change was committed. > > > > > > > Great! > > > > It is not only master.passwd, it is also group and several other config > > files, I suspect it is the whole bunch of files located in /etc/ getting > > reset to their initial file values. > > > > My OpenLDAP environment isn't working anymore due to /etc/pam.d reset. X11 > > doesn't start anymore due to reset of /etc/ttys. also, sysctl.conf has been > > reset. > > > > I haven't figured out so far how far this goes. Lucky for those having > > recent /etc/ backups. A pity FreeBSD doens't backup this by default. > > > > The change (incorrectly) invoked the 'distribution' target, so anything > that gets "touched" by that will likely be affected. In my case, it is *EVERY* file located in /usr/share/examples/etc which is now reset. That includes also profile and csh.cshrc and fellows. > > You are correct that we should have an additional failsafe for this kind > of thing, not just a subset of files arbitrarily placed in /var/backups > via a periodic(8) script. > > Glen >