From owner-cvs-all@FreeBSD.ORG  Tue May  1 17:53:24 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 27E5E16A400;
	Tue,  1 May 2007 17:53:24 +0000 (UTC) (envelope-from gad@FreeBSD.org)
Received: from smtp7.server.rpi.edu (smtp7.server.rpi.edu [128.113.2.227])
	by mx1.freebsd.org (Postfix) with ESMTP id DABE613C459;
	Tue,  1 May 2007 17:53:21 +0000 (UTC) (envelope-from gad@FreeBSD.org)
Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47])
	by smtp7.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l41HrIM7012271;
	Tue, 1 May 2007 13:53:19 -0400
Mime-Version: 1.0
Message-Id: <p06240806c25d2d7872e6@[128.113.24.47]>
In-Reply-To: <Pine.GSO.4.64.0705011310490.2591@sea.ntplx.net>
References: <200705011602.l41G2iRx003626@repoman.freebsd.org>
	<Pine.GSO.4.64.0705011310490.2591@sea.ntplx.net>
Date: Tue, 1 May 2007 13:53:17 -0400
To: Daniel Eischen <deischen@FreeBSD.org>,
	"Andrey A. Chernov" <ache@FreeBSD.org>
From: Garance A Drosehn <gad@FreeBSD.org>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
X-RPI-SA-Score: undef - spam scanning disabled
X-CanItPRO-Stream: default
X-Canit-Stats-ID: Bayes signature not available
X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.227
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 May 2007 17:53:24 -0000

At 1:12 PM -0400 5/1/07, Daniel Eischen wrote:
>On Tue, 1 May 2007, Andrey A. Chernov wrote:
>>
>>  Modified files:
>>    lib/libc/stdlib      getenv.3 getenv.c putenv.c setenv.c
>>    sys/sys              param.h
>>    usr.bin/limits       limits.c
>>    usr.bin/env          env.c
>>    usr.sbin/sysinstall  main.c variable.c
>>    usr.sbin/pstat       pstat.c
>>    usr.sbin/sade        main.c variable.c
>>    bin/sh               var.c
>>    usr.bin/login        login.c
>>    usr.bin/su           su.c
>>    libexec/pppoed       pppoed.c
>>    usr.bin/du           du.c
>>    bin/df               df.c
>>    include              stdlib.h
>>  Log:
>>  Back out all POSIXified *env() changes.
>
>Uh, please put them back in.  This is -current and we do want
>to be conformant with POSIX where possible.

I know you (Andrey) have gotten a lot of flak about the changes
to getenv/putenv, and I do think the changes to those routines
could have been phased in a better way than they were.

But I expect the fixes to *other* programs (such as usr.bin/env)
could be committed without causing any trouble for anyone.  If
that's true, then we might as well leave those changes in.

-- 
Garance Alistair Drosehn     =               drosehn@rpi.edu
Senior Systems Programmer               or   gad@FreeBSD.org
Rensselaer Polytechnic Institute;             Troy, NY;  USA