From owner-svn-src-head@FreeBSD.ORG Thu Jul 28 02:59:33 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BBA8106566B; Thu, 28 Jul 2011 02:59:33 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id E9EE78FC08; Thu, 28 Jul 2011 02:59:32 +0000 (UTC) Received: by gyf3 with SMTP id 3so1942399gyf.13 for ; Wed, 27 Jul 2011 19:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=aAjfBZnqaueGj4T/eD9O8KM8z0RzFnZ1cJ/+bMUBzWI=; b=fGvpn4Wpa94HybPC2j5WxFzVZEYON5sb3+rXfzogN4fN0+DZken40CqKNvNu2kJY3x ZRIaHphL157aEWgmAgJx8FyYVWw6n+9Cva54VM9LG1NTL2wPfTGzVEExeJTXyRmNYsUH a98o6Ii4wSVduBrwZIuqDceYTzbozBDKdaMJQ= MIME-Version: 1.0 Received: by 10.236.175.35 with SMTP id y23mr345261yhl.495.1311821972006; Wed, 27 Jul 2011 19:59:32 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.108.129 with HTTP; Wed, 27 Jul 2011 19:59:31 -0700 (PDT) In-Reply-To: References: <201107191241.p6JCfvqw072816@svn.freebsd.org> <4E2C9012.602@freebsd.org> <4E2DB8AC.3000703@FreeBSD.org> <4E2DBCBF.2030402@freebsd.org> Date: Wed, 27 Jul 2011 22:59:31 -0400 X-Google-Sender-Auth: C5GCgNSijjRJyWnkavGYrtMAd5I Message-ID: From: Attilio Rao To: Nathan Whitehorn Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Sergey Kandaurov , Andreas Tobler Subject: Re: svn commit: r224216 - in head/sys: ia64/ia64 mips/mips powerpc/aim sparc64/sparc64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2011 02:59:33 -0000 I think that the following patch may better reflect the definition of size_t: http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff Do you think you can test it out? Thanks, Attilio 2011/7/25 Attilio Rao : > Guys, I'm a bit out of that for a couple of days, flying to another > continent, I'm not entirely sure the patch is right because I think we > need an unified approach for specifying a 32-bits value, but you can > check-in as a showstopper for the moment, I will make a better one in > a couple of days. > > Attilio > > 2011/7/25 Nathan Whitehorn : >> On 07/25/11 13:40, Andreas Tobler wrote: >>> >>> On 24.07.11 23:35, Nathan Whitehorn wrote: >>>> >>>> On 07/19/11 07:41, Attilio Rao wrote: >>>>> >>>>> Author: attilio >>>>> Date: Tue Jul 19 12:41:57 2011 >>>>> New Revision: 224216 >>>>> URL: http://svn.freebsd.org/changeset/base/224216 >>>>> >>>>> Log: >>>>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes >>>>> storage. >>>>> Fix the sintrcnt/sintrnames specification. >>>>> >>>>> No MFC is previewed for this patch. >>>>> >>>> >>>> These also need to be .long on 32-bit PowerPC, otherwise this change >>>> triggers kernel panics and faults in sysctl. Please change it as quickly >>>> as possible. >>> >>> Like the below? >>> >>> I'll test and I could commit if ok. (Build and approval) >>> >>> Gruss, >>> Andreas >>> >>> Index: locore32.S >>> =================================================================== >>> --- locore32.S (revision 224326) >>> +++ locore32.S (working copy) >>> @@ -91,13 +91,13 @@ >>> GLOBAL(intrnames) >>> .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>> GLOBAL(sintrnames) >>> - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>> + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>> >>> .align 4 >>> GLOBAL(intrcnt) >>> .space INTRCNT_COUNT * 4 * 2 >>> GLOBAL(sintrcnt) >>> - .word INTRCNT_COUNT * 4 * 2 >>> + .long INTRCNT_COUNT * 4 * 2 >>> >>> .text >>> .globl btext >> >> Exactly like that. >> -Nathan >> > > > > -- > Peace can only be achieved by understanding - A. Einstein > -- Peace can only be achieved by understanding - A. Einstein