From owner-cvs-src@FreeBSD.ORG  Fri Dec 15 20:01:58 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 39E2A16A40F;
	Fri, 15 Dec 2006 20:01:58 +0000 (UTC)
	(envelope-from syrinx@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B97D943CA7;
	Fri, 15 Dec 2006 20:00:14 +0000 (GMT)
	(envelope-from syrinx@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBFK1vOU019968;
	Fri, 15 Dec 2006 20:01:57 GMT
	(envelope-from syrinx@repoman.freebsd.org)
Received: (from syrinx@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBFK1vne019967;
	Fri, 15 Dec 2006 20:01:57 GMT (envelope-from syrinx)
Message-Id: <200612152001.kBFK1vne019967@repoman.freebsd.org>
From: Shteryana Shopova <syrinx@FreeBSD.org>
Date: Fri, 15 Dec 2006 20:01:57 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c
 bridge_if.c bridge_pf.c bridge_port.c bridge_snmp.c bridge_sys.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2006 20:01:58 -0000

syrinx      2006-12-15 20:01:57 UTC

  FreeBSD src repository

  Modified files:
    usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c bridge_if.c 
                                        bridge_pf.c bridge_port.c 
                                        bridge_snmp.c bridge_sys.c 
  Log:
  Do not add 'default:' cases inside a switch() on an enum like the
  SNMP option argument. That way the compiler will give a warning in
  case of a missing or an extra but unknown 'case:'.
  Do the same for SNMP LEAF objects to be prepared once gensnmptree will
  auto-generate enums for those too.
  Add an abort() after the switch() instead of the 'default:' to catch
  any errors. The nice side effect is that the compiler will correctly
  track supposed to be 'uninitialized' variables with that.
  
  When trying to set a value sanity check it before calling the OS
  dependent API of snmp_bridge to tell whether it is an attempt to
  set a bad value or a general error.
  
  Suggested by:   harti (first part)
  Approved by:    bz (mentor)
  
  Revision  Changes    Path
  1.3       +18 -22    src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_addrs.c
  1.4       +196 -152  src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_if.c
  1.2       +14 -15    src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_pf.c
  1.4       +256 -175  src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_port.c
  1.3       +13 -10    src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_snmp.c
  1.3       +1 -43     src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_sys.c