From owner-freebsd-hackers  Fri Aug 27 13:34:16 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from dorifer.heim3.tu-clausthal.de (dorifer.heim3.tu-clausthal.de [139.174.243.252])
	by hub.freebsd.org (Postfix) with ESMTP id EA29E15012
	for <freebsd-hackers@FreeBSD.ORG>; Fri, 27 Aug 1999 13:34:07 -0700 (PDT)
	(envelope-from olli@dorifer.heim3.tu-clausthal.de)
Received: (from olli@localhost)
	by dorifer.heim3.tu-clausthal.de (8.8.8/8.8.8) id WAA12801
	for freebsd-hackers@FreeBSD.ORG; Fri, 27 Aug 1999 22:32:30 +0200 (CEST)
	(envelope-from olli)
Date: Fri, 27 Aug 1999 22:32:30 +0200 (CEST)
From: Oliver Fromme <olli@dorifer.heim3.tu-clausthal.de>
Message-Id: <199908272032.WAA12801@dorifer.heim3.tu-clausthal.de>
To: freebsd-hackers@FreeBSD.ORG
Subject: Re: Please review: rc file changes
Organization: Administration Heim 3
Reply-To: freebsd-hackers@FreeBSD.ORG
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-Newsreader: TIN [version 1.2 RZTUC(3) PL2]
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Maybe this is nit-picking, too, buth those are just
my 0.02 Euros...

Doug wrote in list.freebsd-hackers:
 > -# this file, but rather in /etc/defaults/rc.conf.  Please check this file
 > +# this file, but rather in /etc/defaults/rc.conf. Please check that file

I'd prefer to keep it with two spaces, to improve
readability.

 >  	case $? in
 > -	0)
 > +	0 )
 >  		;;
 > -	2)
 > +	2 )
 >  		exit 1
 >  		;;
 > -	4)
 > +	4 )

I have yet to see a good reason for adding those
spaces.  I don't like them, but that's just me...

Apart from the above -- Good work, Doug!

Regards
   Oliver

-- 
Oliver Fromme, Leibnizstr. 18/61, 38678 Clausthal, Germany
(Info: finger userinfo:olli@dorifer.heim3.tu-clausthal.de)

"In jedem Stück Kohle wartet ein Diamant auf seine Geburt"
                                         (Terry Pratchett)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message