From owner-dev-commits-src-main@freebsd.org Sat May 15 22:42:09 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 29D4F629A7F for ; Sat, 15 May 2021 22:42:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FjL4K0N2jz4Ywx for ; Sat, 15 May 2021 22:42:09 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f52.google.com with SMTP id h4so2572438wrt.12 for ; Sat, 15 May 2021 15:42:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=F7NT+d9CyIVNEdF3LuF2NMB/isI8Z051uKvErSixD3o=; b=ggam76TK8F238BpO4IDyyJ+HjxqJBMm2LDtgAYNva4RGOzFUz+s5sBzbBlDFQg+hWM KSdoVZbshLL3y6IXPuY+g5rZQsqWaTLohCUv0gOOTMPTpMry+9cnFQlnYgIyMV3XVK/C C36i88A410JZV/Fzr2pI6oE2KX42cYT4V2Cj6vdOJptsqNVOVYrR+J6dsOX1c80m9pu0 mRdRHBckvA/2oXLeQQ/ktWg2hnLigN2/eQHS7Tp5mDbwPR2fGj4lcSEHRTOLQ8FCZYQJ wvbGQ0aIIUrpJtboBnH5OwUyr76UKjcypZQEEoSC0kPUXouPsdGxCdr5CDOxWBgRzL+P pf9g== X-Gm-Message-State: AOAM532QNJc0GdclhNe9UNmdTL+d5tPnbgAFZ0E5rNekF5QFp7iGeP2o C13qsoPOfu6NH/vZ1d9WcLGxUg== X-Google-Smtp-Source: ABdhPJxMCn1m6Q6Vt+IF7pmyxy1F8CxguUj8k19zOHo7zqJAZTbbaXipbKRq3nzJLGH2APlA+3vxzQ== X-Received: by 2002:a5d:4408:: with SMTP id z8mr3869094wrq.2.1621118527506; Sat, 15 May 2021 15:42:07 -0700 (PDT) Received: from [192.168.150.48] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id v10sm12664092wrq.0.2021.05.15.15.42.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 May 2021 15:42:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup From: Jessica Clarke In-Reply-To: <20210515223634.GA21814@belenus.iks-jena.de> Date: Sat, 15 May 2021 23:42:06 +0100 Cc: Konstantin Belousov , Lutz Donnerhacke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <20210515195812.GB17734@belenus.iks-jena.de> <20210515205133.GA19770@belenus.iks-jena.de> <20210515223634.GA21814@belenus.iks-jena.de> To: Lutz Donnerhacke X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4FjL4K0N2jz4Ywx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 22:42:09 -0000 On 15 May 2021, at 23:36, Lutz Donnerhacke wrote: >=20 > On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote: >>> The LIBALIAS_LOCK_ASSERT and the variable declarations were not = moved. >> So you changed some style, but left the large violation in place. >=20 > This cleanup is a preparation to fix various issues in this code. > So yes, the change was intentionally limited to style issues. >=20 > Mixing style and functional changes makes it very hard to track down a > broken behavior to a single commit. This change is huge, it must not = break > anything. I think you two are talking past each other. kib@=E2=80=99s point is = that some of the changes made in this commit were style *changes* not style *fixes* (i.e. = the code was compliant before, you=E2=80=99ve just changed it from one = acceptable formatting to another), and that there were instances of significant = style violations *not* fixed (e.g. the assertion macro before variable = declarations pointed out). He is not talking about functional violations, only style = ones. However, in your defence, your original commit did not claim to fix = *all* style violations, only "most annoying style errors", though that doesn=E2=80=99t= account for unnecessary churn as seen with the blank lines at the starts of = functions. Jess