From owner-freebsd-xen@freebsd.org Thu May 24 15:24:20 2018 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 072F5EF4B70 for ; Thu, 24 May 2018 15:24:20 +0000 (UTC) (envelope-from pratiy0100@gmail.com) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77F7B72456 for ; Thu, 24 May 2018 15:24:19 +0000 (UTC) (envelope-from pratiy0100@gmail.com) Received: by mail-wm0-f65.google.com with SMTP id j4-v6so6276403wme.1 for ; Thu, 24 May 2018 08:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4duavV0QNy1essYvsyrMREe9E/luFG1Kcnbvik2hV5s=; b=XwwQoBIH/FG7ylVxaDvGe2e+EKq6X3Ij07pjuC95Cj9glKRSyoL3uBi0HekyRurJob RQmUWvpxKX9sG4UwZUXcxjfXcyJifyxaqCdqcT4GyCBVhU/4do+3pA/NsQ9oZ6Qr3lV9 Zi3cjyMLPmtM7YZENKoZ9bGjv7djm8q5VXEYvLaAd3AKwi/tFGwk8iDVm9UAcBkNFcko us08SR2j5gCM3N7q/wk22ztb4hj51mMSsKLc+ijYnsmXx/zhZAUzltSoFrPO8t3CG+a+ e84Y4B3ZpbBUOl4mFC2XoNlmthLNf1hivNBQgZ8lkuoNemHuK3HhbJRIREqjChymzHnu bX6g== X-Gm-Message-State: ALKqPweST0v8Io297n3P4mfEOGrsXoLHocsAxyotBWCSzcYCUkS1z3r8 D1ylqESB+kVr2A7t0dmAGMfaLpfyLxs= X-Google-Smtp-Source: AB8JxZpq48YJDHs3ihn3cMK0asSOwst1Qu1R1fxyieOfN4GHaBXkWQ6HTZvXh5ObmWEH7MBx5d3ALg== X-Received: by 2002:a50:d6d9:: with SMTP id l25-v6mr12812019edj.259.1527175457978; Thu, 24 May 2018 08:24:17 -0700 (PDT) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com. [74.125.82.44]) by smtp.gmail.com with ESMTPSA id 49-v6sm12198644edz.87.2018.05.24.08.24.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 08:24:17 -0700 (PDT) Received: by mail-wm0-f44.google.com with SMTP id a67-v6so6213505wmf.3 for ; Thu, 24 May 2018 08:24:17 -0700 (PDT) X-Received: by 2002:a50:fd12:: with SMTP id i18-v6mr12883702eds.158.1527175457714; Thu, 24 May 2018 08:24:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:aa21:0:0:0:0:0 with HTTP; Thu, 24 May 2018 08:23:37 -0700 (PDT) In-Reply-To: <20180524151201.gtpey5wifislq3z2@MBP-de-Roger.citrite.net> References: <20180524140636.7vz2gjshqow6efwe@MBP-de-Roger.citrite.net> <20180524151201.gtpey5wifislq3z2@MBP-de-Roger.citrite.net> From: Pratyush Yadav Date: Thu, 24 May 2018 20:53:37 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Leftover code in gnttab.h? To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: FreeBSD-Xen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 15:24:20 -0000 On Thu, May 24, 2018 at 8:42 PM, Roger Pau Monn=C3=A9 wrote: > On Thu, May 24, 2018 at 08:38:30PM +0530, Pratyush Yadav wrote: >> Hi, >> >> On Thu, May 24, 2018 at 7:36 PM, Roger Pau Monn=C3=A9 wrote: >> > On Thu, May 24, 2018 at 05:53:02PM +0530, Pratyush Yadav wrote: >> >> Hi everyone, >> >> >> >> I was reading the Xen grant table code and I noticed that some code i= s >> >> wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have >> >> also attached the "commented out" part down below. >> >> >> >> Is it useful? Is it all right if I submit a patch that removes it? >> > >> > This are leftovers from when the code was imported from Linux AFAICT. >> > I guess the original committer thought that those functions would be >> > implemented, so the prototypes where left in place. >> > >> > If you give me a patch to remove them I'm happy to commit it. >> >> How should I send you the patch? Should I send it through >> reviews.freebsd.org, GitHub pull request or just paste the patch in >> the email? > > Let's use reviews.freebsd.org, so that you can get used to it. In case you didn't get the notificaton: https://reviews.freebsd.org/D15553 --=20 Regards, Pratyush Yadav