From owner-cvs-all Wed Aug 22 0:46:29 2001 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 62E7537B40E for ; Wed, 22 Aug 2001 00:46:19 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4143 invoked from network); 22 Aug 2001 07:46:18 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 22 Aug 2001 07:46:18 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010822150135.X5785-100000@besplex.bde.org> Date: Wed, 22 Aug 2001 00:46:25 -0700 (PDT) From: John Baldwin To: Bruce Evans Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 22-Aug-01 Bruce Evans wrote: > On Tue, 21 Aug 2001, John Baldwin wrote: > >> jhb 2001/08/21 15:55:20 PDT >> >> Modified files: >> sys/kern kern_shutdown.c >> Log: >> Allow one to restart from a panic in DDB by clearing the panicstr >> variable to NULL. Note that since panic() is marked with __dead2, this >> has somewhat unpredictable results at best. > > Such as "never" working? :-) On i386's panic() has no function epilogue > or return statement, so you have to do these manually to get it to > return. Then the caller may be missing stack cleanups... The easiest > workaround is to declare panic() as returning, but this will cause > lots of compiler warnings. It works sometimes. :) Perhaps what I should do is wrap this in some option (RESTARTABLE_PANICS maybe) and if it is on turn off _dead2 on panic(). > Bruce -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message