From owner-freebsd-current Thu Jan 23 15:17:40 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A373437B401 for ; Thu, 23 Jan 2003 15:17:39 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 33C4D43F6B for ; Thu, 23 Jan 2003 15:17:38 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 73071 invoked by uid 1000); 23 Jan 2003 23:17:38 -0000 Date: Thu, 23 Jan 2003 15:17:38 -0800 (PST) From: Nate Lawson To: Juli Mallett Cc: current@FreeBSD.org Subject: Re: Test this! Patch to make newfs(8) use libufs. In-Reply-To: <20030123142924.A61481@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 23 Jan 2003, Juli Mallett wrote: > * De: Nate Lawson [ Data: 2003-01-23 ] > [ Subjecte: Re: Test this! Patch to make newfs(8) use libufs. ] > > On Thu, 23 Jan 2003, Juli Mallett wrote: > > > Thanks to Ruslan's reminder that tunefs now uses libufs and tunefs is > > > one of the crunched programs, I realised that I really needed to make > > > newfs(8) use libufs. To show off that it *can* help us reduce space, > > > a good bit in some cases. > > > > Good to see this. Does libufs do an fsync() in bwrite() or do you need to > > do that manually in place of the previous calls to wtfsflush()? > > It doesn't. Do you think it should? I'd rather do that than litter the > newfs code. Not needed. On second look, I see you removed the wc[] caching and fall back to just write(). (BTW, what's the performance difference with your patch?) If newfs doesn't complete successfully due to a system crash, it doesn't matter if data written was flushed to disk, just run it again. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message