From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 8 20:20:05 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01D71106568F for ; Mon, 8 Feb 2010 20:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BA8B58FC27 for ; Mon, 8 Feb 2010 20:20:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o18KK4R6065202 for ; Mon, 8 Feb 2010 20:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o18KK4BW065201; Mon, 8 Feb 2010 20:20:04 GMT (envelope-from gnats) Resent-Date: Mon, 8 Feb 2010 20:20:04 GMT Resent-Message-Id: <201002082020.o18KK4BW065201@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Joseph S. Atkinson" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78D5B106566C for ; Mon, 8 Feb 2010 20:14:34 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 688088FC0C for ; Mon, 8 Feb 2010 20:14:34 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o18KEYRO039751 for ; Mon, 8 Feb 2010 20:14:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o18KEYq6039750; Mon, 8 Feb 2010 20:14:34 GMT (envelope-from nobody) Message-Id: <201002082014.o18KEYq6039750@www.freebsd.org> Date: Mon, 8 Feb 2010 20:14:34 GMT From: "Joseph S. Atkinson" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/143678: Remove update checks from ftp/filezilla X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2010 20:20:05 -0000 >Number: 143678 >Category: misc >Synopsis: Remove update checks from ftp/filezilla >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 08 20:20:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Joseph S. Atkinson >Release: >Organization: >Environment: >Description: By default, FileZilla has automatic update checks enabled. For FreeBSD, this is a bit pointless since SF doesn't build packages for us. This might just cause some false alarm that the software is unmaintained in the interim between release, port update, and packages being pushed to the FTP servers. At the very least, it's mostly irrelevant pop up spam for FreeBSD users that will show at every application launch if their version is not the most current. This bump disables this behavior unless MAINTAINER_MODE is defined. >How-To-Repeat: >Fix: Patch attached with submission follows: diff -ru /usr/ports/ftp/filezilla/Makefile filezilla/Makefile --- /usr/ports/ftp/filezilla/Makefile 2010-02-06 15:32:36.000000000 -0500 +++ filezilla/Makefile 2010-02-08 14:57:05.000000000 -0500 @@ -7,7 +7,7 @@ PORTNAME= filezilla PORTVERSION= 3.3.1 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= ftp MASTER_SITES= SF/${PORTNAME}/FileZilla_Client/${PORTVERSION} DISTNAME= FileZilla_${PORTVERSION}_src @@ -51,6 +51,10 @@ PLIST_SUB+= NLS="@comment " .endif +.if !defined(MAINTAINER_MODE) +CONFIGURE_ARGS+= --disable-manualupdatecheck +.endif + post-patch: @${REINPLACE_CMD} -Ee 's|(dummy) wxrc|\1 ${WXRC_CMD:T}|' \ ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} >Release-Note: >Audit-Trail: >Unformatted: