From owner-freebsd-python@FreeBSD.ORG Tue Oct 2 17:55:15 2012 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 74955106566C; Tue, 2 Oct 2012 17:55:15 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net [IPv6:2a02:6b8:0:f05::2]) by mx1.freebsd.org (Postfix) with ESMTP id DBD4D8FC0C; Tue, 2 Oct 2012 17:55:14 +0000 (UTC) Received: from smtp4h.mail.yandex.net (smtp4h.mail.yandex.net [84.201.186.21]) by forward2h.mail.yandex.net (Yandex) with ESMTP id B56707020A0; Tue, 2 Oct 2012 21:55:13 +0400 (MSK) Received: from smtp4h.mail.yandex.net (localhost [127.0.0.1]) by smtp4h.mail.yandex.net (Yandex) with ESMTP id 409302C0277; Tue, 2 Oct 2012 21:55:13 +0400 (MSK) Received: from unknown (unknown [178.76.224.133]) by smtp4h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id tCrmLPgt-tCrmWNKD; Tue, 2 Oct 2012 21:55:12 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1349200513; bh=krwD2PCpGI6jxG508Y6OrinHI7KYn4MsEqg8LDGB7r4=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=g7gr9lCFeWWm09XsI2U6BueCYwtBqdECL+zalWZy9QPvWtirlh5ESD7m1DybyB7DN pMnnwJaHdSGOmzj/I+grBvqfnsutBYfXGsP3Vq0W0wFNRtsnwqvUYiaeUDScbYLzfY BUY0fxXgRHN+vDFIC6rmKp/cbFRmcreUAKCGQ/js= Message-ID: <506B2A7C.5060301@yandex.ru> Date: Tue, 02 Oct 2012 21:55:08 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Li-Wen Hsu References: <50698A96.4000301@yandex.ru> <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu> <5069DB04.5080806@yandex.ru> <20121001181100.GA90625@FreeBSD.cs.nctu.edu.tw> In-Reply-To: <20121001181100.GA90625@FreeBSD.cs.nctu.edu.tw> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Rees , Marcus von Appen , python Subject: Re: Python distribution: switching to tar.xz X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2012 17:55:15 -0000 Li-Wen Hsu wrote on 01.10.2012 22:11: > On Mon, Oct 01, 2012 at 22:03:48 +0400, Ruslan Mahmatkhanov wrote: >> Li-Wen Hsu wrote on 01.10.2012 21:51: >>> >>> EXTRACT_SUFX?= .tgz >>> PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}}${EXTRACT_SUFX} >> >> Yes, I also bow to this option. >> >>> then we can define USE_XZ= yes in the ports we want to use xz >>> distfile, which handles >>> ${EXTRACT_SUFX} and ${EXTRACT_DEPENDS} correctly. After python26 decommission, >>> we can even move this into bsd.python.mk >> >> python26 distributes in tar.xz too [1]. Or you meant something other? >> >> Ok, so I get the point. I'll prepare an patch that make ${EXTRACT_SUFX} >> redefinable for python ports, so we can gradually switch all this ports >> to xz. Thanks Marcus and Li-Wen. >> >> [1] http://www.python.org/ftp/python/2.6.8/Python-2.6.8.tar.xz >> > > Oh I was not aware that, I just did not see XZ information at: > > http://python.org/download/releases/2.6.8/ > > So maybe we can simply put USE_XZ= yes in bsd.python.mk now. Ok, here is the patch [1]. Unfortunately, we can't just include USE_XZ into bsd.python.mk because this will affect *all* the ports, that define USE_PYTHON in their Makefile's. I can't think a way how to (nicely) apply USE_XZ to limited set of ports inside of bsd.python.mk. Using tar.xz instead of .tgz in ${PYTHON_DISTFILE} will not work on systems, that lacks xz in a base system and I dislike the duplication of USE_XZ internals in bsd.python.mk for them. So this patch just replaces .tgz with ${EXTRACT_SUFX} and USE_XZ is used in individual python ports. I did some test builds of python and it's slaves (py-sqlite3, py-bdsdb, py-gdbm, py-tkinter) and everything seems fine. I also diffed all the four pairs tgz/tar.xz of each python version - and, as it was expected, their content is equal. Any objections, suggestions etc? [1] http://people.freebsd.org/~rm/tgz-to-tx-conversion.diff.txt -- Regards, Ruslan Tinderboxing kills... the drives.