From nobody Wed Dec 6 09:57:58 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SlXsB2zxxz539g5; Wed, 6 Dec 2023 09:58:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SlXsB04WPz3MWX; Wed, 6 Dec 2023 09:58:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.17.1/8.17.1) with ESMTP id 3B69vwgP093433; Wed, 6 Dec 2023 11:58:01 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 3B69vwgP093433 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 3B69vwsk093432; Wed, 6 Dec 2023 11:57:58 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 6 Dec 2023 11:57:58 +0200 From: Konstantin Belousov To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 14dcd4098374 - main - linuxkpi: `GFP_KERNEL` equals `M_NOWAIT` now Message-ID: References: <202311241731.3AOHVsEJ061730@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SlXsB04WPz3MWX On Wed, Dec 06, 2023 at 09:46:53AM +0100, Jean-Sébastien Pédron wrote: > On 06/12/2023 00:52, Konstantin Belousov wrote: > > Unfortunately this broke even attach of the mlx5(4) driver. > > According to the 'official' Linux kernel documentation, the GFP_KERNEL > > flag implies sleepable context. mlx5_core uses the passed GFP flag to > > determine if it is called in the sleepable context, and now even initial > > load assumes that it cannot perform sleeping ops. See, for instance, > > second if() statement in the mlx5_fwp_alloc() function. > > Oh sorry... Thank you for reporting the issue. I will revisit this change > then. Should I revert it in main until there is a solution? Up to you. I do not see a need in churn if the fix would come in several days. Thank you.