From owner-freebsd-security@FreeBSD.ORG Thu May 19 12:43:55 2005 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27BC716A4CF; Thu, 19 May 2005 12:43:55 +0000 (GMT) Received: from eddie.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39C9B43DB9; Thu, 19 May 2005 12:43:54 +0000 (GMT) (envelope-from simon@eddie.nitro.dk) Received: by eddie.nitro.dk (Postfix, from userid 1000) id A002E119C4C; Thu, 19 May 2005 14:43:52 +0200 (CEST) Date: Thu, 19 May 2005 14:43:52 +0200 From: "Simon L. Nielsen" To: Max Okumoto Message-ID: <20050519124351.GA24413@eddie.nitro.dk> References: <200505121545.j4CFjENu078768@repoman.freebsd.org> <20050512180743.6z1h22fldwksgw4w@netchild.homeip.net> <42897003.2090005@ucsd.edu> <20050517144446.gibxprydoosokw0k@netchild.homeip.net> <428A23A2.5080108@ucsd.edu> <20050518100548.h8r4qc59c08swoog@netchild.homeip.net> <20050518141456.GB40240@orion.daedalusnetworks.priv> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i cc: freebsd-security@freebsd.org cc: Alexander Leidinger cc: Giorgos Keramidas Subject: Re: cvs commit: src/usr.bin/make job.c X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Security issues [members-only posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2005 12:43:55 -0000 --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2005.05.18 08:41:14 -0700, Max Okumoto wrote: > Alexander suggested that I replace that code with > mkdtemp(template) > mkfifo(tempalte + "/fifo") >=20 > Which removed alot of the code duplication, but added the race > back in. [...] Ehh, where is the race? mkdtemp creates a unique directory with permissions 0700 so nobody else can race make(1) to the fifo in the temporary... or am I missing something? --=20 Simon L. Nielsen --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCjIoHh9pcDSc1mlERAka1AJ0RQkmhA/tH0QFM4kSyuw80H4cdpQCgtV7f idxRSQv7KRdi9RTmXJPUym8= =PY9+ -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--