From owner-svn-src-head@freebsd.org Wed Jul 4 14:07:30 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65E2C103A5A9; Wed, 4 Jul 2018 14:07:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B15957D1CB; Wed, 4 Jul 2018 14:07:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id aiRJfDxNEogHjaiRKfy8vS; Wed, 04 Jul 2018 08:07:28 -0600 X-Authority-Analysis: v=2.3 cv=Sre+FsG0 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=R9QF1RCXAYgA:10 a=vaJtXVxTAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=VxmjJ2MpAAAA:8 a=15uXNp85ToZJJYQ7xH8A:9 a=CjuIK1q_8ugA:10 a=9T6p9fL4ueEA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=7gXAzLPJhVmCkEl4_tsf:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 0A804145; Wed, 4 Jul 2018 07:07:25 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w64E7O8b080440; Wed, 4 Jul 2018 07:07:24 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w64E7NxV080432; Wed, 4 Jul 2018 07:07:23 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201807041407.w64E7NxV080432@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Andrey V. Elsukov" cc: Cy Schubert , Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335919 - head/sys/netinet6 In-Reply-To: Message from "Andrey V. Elsukov" of "Wed, 04 Jul 2018 16:31:04 +0300." <13fa004f-6d8a-025e-9d4f-957f081113b4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 04 Jul 2018 07:07:23 -0700 X-CMAE-Envelope: MS4wfBD75Bg2+7Xhaeby8lWDoJLhFeM+C3KTP5It+aHUoTUcOpsrq8ELDNstUeGvYOEY+N5QvXG7pgyKxLKS/PCSanDq+kTIpa9xQfR2RMws6/rujQOcK+Br pGB0A4P18sdhaL7U0WA8ER/bMMn217z0N/IUeIY+dRoZt9/0fQIbNlX9uNIV2HEBs+cZ70lhZKAghZwQIn0LMfolAc7kUW/WKek/DQ7QBINRRESB4DNs5yRt CO7ht9XYXjM9imELbpsNfnkOBSNbOiWNwzH4rxuN5WghGOFsPPO9iRonefnwAPWJ X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 14:07:30 -0000 In message <13fa004f-6d8a-025e-9d4f-957f081113b4@yandex.ru>, "Andrey V. Elsukov " writes: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --DYq4DERiQq8E3pDWhQQJu3pRxNkEa3XRw > Content-Type: multipart/mixed; boundary="3UyYmNTJPMJYH4JeWdQTZY41T0JnKZ9UW"; > protected-headers="v1" > From: "Andrey V. Elsukov" > To: Cy Schubert , Matt Macy > Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, > svn-src-head@freebsd.org > Message-ID: <13fa004f-6d8a-025e-9d4f-957f081113b4@yandex.ru> > Subject: Re: svn commit: r335919 - head/sys/netinet6 > References: <201807041305.w64D5qiK002898@slippy.cwsent.com> > In-Reply-To: <201807041305.w64D5qiK002898@slippy.cwsent.com> > > --3UyYmNTJPMJYH4JeWdQTZY41T0JnKZ9UW > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > On 04.07.2018 16:05, Cy Schubert wrote: > > Hi Matt, > >=20 > > This is causing a panic of my gateway machine. Likely due to router=20 > > solicitations. > > Hi, > > probably in the last two chunks "inp" should be replaced with "last" > > Index: udp6_usrreq.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- udp6_usrreq.c (revision 335934) > +++ udp6_usrreq.c (working copy) > @@ -387,7 +387,7 @@ udp6_input(struct mbuf **mp, int *offp, int proto) > if ((n =3D m_copym(m, 0, M_COPYALL, M_NOWAIT)) > !=3D > NULL) { > INP_RLOCK(last); > - if (__predict_true(inp->inp_flags2 & IN > P_FREED) =3D=3D 0) { > + if (__predict_true(last->inp_flags2 & I > NP_FREED) =3D=3D 0) { > UDP_PROBE(receive, NULL, last, > ip6, > last, uh); > if (udp6_append(last, n, off, f > romsa)) > @@ -421,7 +421,7 @@ udp6_input(struct mbuf **mp, int *offp, int proto) > goto badheadlocked; > } > INP_RLOCK(last); > - if (__predict_true(inp->inp_flags2 & INP_FREED) =3D=3D 0) { > + if (__predict_true(last->inp_flags2 & INP_FREED) =3D=3D 0) { > UDP_PROBE(receive, NULL, last, ip6, last, uh); > if (udp6_append(last, m, off, fromsa) =3D=3D 0) > INP_RUNLOCK(last); > > > --=20 > WBR, Andrey V. Elsukov Makes sense. Gave it a spin before heading off to $JOB. No more panic loop. Thanks. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.