From owner-freebsd-bugs@FreeBSD.ORG Sat Apr 23 19:50:12 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC2801065675 for ; Sat, 23 Apr 2011 19:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 98A718FC15 for ; Sat, 23 Apr 2011 19:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3NJoCbf077821 for ; Sat, 23 Apr 2011 19:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3NJoCbh077820; Sat, 23 Apr 2011 19:50:12 GMT (envelope-from gnats) Resent-Date: Sat, 23 Apr 2011 19:50:12 GMT Resent-Message-Id: <201104231950.p3NJoCbh077820@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stephen Hurd Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 967C21065677 for ; Sat, 23 Apr 2011 19:46:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 854758FC0A for ; Sat, 23 Apr 2011 19:46:10 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p3NJkAZm032909 for ; Sat, 23 Apr 2011 19:46:10 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p3NJkATt032908; Sat, 23 Apr 2011 19:46:10 GMT (envelope-from nobody) Message-Id: <201104231946.p3NJkATt032908@red.freebsd.org> Date: Sat, 23 Apr 2011 19:46:10 GMT From: Stephen Hurd To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/156601: New dialog.h undefines ERR making curses macros unavailable X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2011 19:50:12 -0000 >Number: 156601 >Category: misc >Synopsis: New dialog.h undefines ERR making curses macros unavailable >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Apr 23 19:50:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Stephen Hurd >Release: 9.0-CURRENT >Organization: >Environment: FreeBSD 9.0-CURRENT FreeBSD 9.0-CURRENT #1: Sat Apr 23 10:37:10 UTC 2011 root@:/usr/obj/usr/src/sys/GENERIC i386 >Description: The new dialog.h on line 47 undefines the ERR macro with a comment of "header conflict with Solaris xpg4" this means that if n?curses.h is included before dialog.h, ERR becomes undefined and the various macros in curses.h (ie: getmaxy()) break. Since our curses.h #undef's ERR itself, there is no need for this in FreeBSD, and since it requires specific #include ordering for no good reason, it should be removed. >How-To-Repeat: #include #include #include int main(int argc, char **argv) { initscr(); fprintf(stderr, "%d\n", getmaxy(stdscr)); endwin(); return 0; } >Fix: Remove line 47 of dialog.h for FreeBSD >Release-Note: >Audit-Trail: >Unformatted: