From owner-freebsd-net@FreeBSD.ORG Thu Apr 5 00:15:08 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 00C0316A405 for ; Thu, 5 Apr 2007 00:15:08 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id AC96B13C484 for ; Thu, 5 Apr 2007 00:15:07 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by an-out-0708.google.com with SMTP id c24so457337ana for ; Wed, 04 Apr 2007 17:15:07 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=knqAwGB96FQ4bVyYkV53va7acCEfK0EqXStFWvETx6gTbk7zfZrawaRcUhwgEvw1JDIYiYnizYsbZj2cL8fsrjHdeeSvQC8dUILUM1pY0EwL5bZjkpv2FPD3U/gDM48gC+mUvf+/K01c9Q6edcVaQpxXtKb/4L70UILMODFo8Ww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=O9D85Ty+DIEkfzP2FFth6OJFH9W7iZYFpG8GPRy7qL8V13obXntguma4rqO3mxaETwuG1/W7ZDy0qkrd+NphWXIWwE2Hl43AUJ9vYP/G6tw0Rw21lVdmZZ0UCW9BLP4vqsxZuyvWml+nPY1v6XDc95pPLicsi/jLGtSxtWYMgLE= Received: by 10.114.111.1 with SMTP id j1mr495774wac.1175732106226; Wed, 04 Apr 2007 17:15:06 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id n22sm3845156pof.2007.04.04.17.15.03; Wed, 04 Apr 2007 17:15:04 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l350FYin016080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Apr 2007 09:15:34 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l350FXq2016079; Thu, 5 Apr 2007 09:15:33 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Thu, 5 Apr 2007 09:15:33 +0900 From: Pyun YongHyeon To: Marv Message-ID: <20070405001533.GA15837@cdnetworks.co.kr> References: <20070404100200.GA1167@home.bh.net> <20070404111158.GB11525@cdnetworks.co.kr> <20070404190649.GB986@home.bh.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <20070404190649.GB986@home.bh.net> User-Agent: Mutt/1.4.2.1i Cc: freebsd-net@freebsd.org Subject: Re: if_msk in 6.2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 00:15:08 -0000 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 04, 2007 at 09:06:49PM +0200, Marv wrote: > Thanks for your reply. I checked out the kernel source tree of RELENG_6, > applied your patch and compiled a new kernel. > > The kernel boots and detects a 88E8038 Ethernet card but then hangs: > > mskc0: irq 16 at device 0.0 on > pci2 > mskc0: 0x4000 bytes of rid 0x10 res 3 failed (0, 0xffffffff). > mskc0: unknown device: id=0xff, rev=0x0f > > (doing nothing no more at this point). > > Was there some kind of detection failure or is my ethernet controller > not configured properly to fit the driver? > Since msk(4) supports 88E8038 I guess the device was not properly initialized/recognized by system BIOS. But it's driver bug if it hang your system when it encounter an exceptional condition. Try attached patch and report back the result. It wouldn't fix device recognization but it will not hang your system. -- Regards, Pyun YongHyeon --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="if_msk.patch2" Index: if_msk.c =================================================================== RCS file: /home/ncvs/src/sys/dev/msk/if_msk.c,v retrieving revision 1.11.2.2 diff -u -r1.11.2.2 if_msk.c --- if_msk.c 2 Apr 2007 01:22:31 -0000 1.11.2.2 +++ if_msk.c 5 Apr 2007 00:12:53 -0000 @@ -1581,8 +1581,8 @@ sc->msk_hw_id > CHIP_ID_YUKON_FE) { device_printf(dev, "unknown device: id=0x%02x, rev=0x%02x\n", sc->msk_hw_id, sc->msk_hw_rev); - error = ENXIO; - goto fail; + mtx_destroy(&sc->msk_mtx); + return (ENXIO); } SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev), --BXVAT5kNtrzKuDFl--