From owner-svn-src-all@freebsd.org Mon Dec 19 20:37:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78370C880AE; Mon, 19 Dec 2016 20:37:31 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 59F6018EE; Mon, 19 Dec 2016 20:37:31 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp002.me.com by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OIG003008O33O00@mr11p00im-asmtp002.me.com>; Mon, 19 Dec 2016 20:37:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1482179845; bh=FwV5vsw81ZWur8RlonKYHLZMbxfOHoFRL23cvRJxKfk=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=sWeroYH2Db+8PQcEOb5uMzEB1zIFBsRbC+G9MwxTPPhHnQNH/lq8bFBdW8eEu+Jxr e9Ec7Xl+b9BYFQNKQsLCkjmlQIZNLOaCuKWxaTezOBRVLFS5IPwHvPs0ESWIkEZgtu zrTsW5IE4QC7nPdkxr/NnmzGtQOMuEI4hBqy6gMYp5AEuyT6axXKG8cHuiGL9RAmG7 aPBhsQAuP6tPdaBLg+ubmac8r4ozGVC73IeA1uxFZJXjo1QtTYxc0FE7/XnBFJSMqM 694E+BaKNVdnY+GzPp8aSlblWJoHTTuQZSuG6mvuZiS3ZSy+xSuN+JYFS444NcD4Fy 11xRX8+vluclw== Received: from [172.17.133.77] (dip-cali.panasas.com [64.80.217.3]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OIG00ET89ABKI10@mr11p00im-asmtp002.me.com>; Mon, 19 Dec 2016 20:37:25 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-19_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612190230 User-Agent: Microsoft-MacOutlook/f.1d.0.161209 Date: Mon, 19 Dec 2016 12:37:27 -0800 Subject: Re: svn commit: r310171 - head/sys/sys From: Ravi Pokala Sender: "Pokala, Ravi" To: Ian Lepore , Warner Losh Cc: Sepherosa Ziehau , Dimitry Andric , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-id: Thread-topic: svn commit: r310171 - head/sys/sys References: <201612161949.uBGJnMol059217@repo.freebsd.org> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> <1482175209.48539.9.camel@freebsd.org> In-reply-to: <1482175209.48539.9.camel@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 20:37:31 -0000 -----Original Message----- > From: on behalf of Ian Lepore > Date: 2016-12-19, Monday at 11:20 > To: Warner Losh , Ravi Pokala > Cc: Sepherosa Ziehau , Dimitry Andric , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" > Subject: Re: svn commit: r310171 - head/sys/sys > > On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote: >> >> ... >> >> Are there other precedence for avoiding the SCN macros in the tree as >> well, or is this new art? >> >> Warner > > There was another commit recently the fixed the same kind of scanf > error by making the variable fit the scanf type (changing uint64_t to > an explicit long long unsigned, iirc). I don't know if that alone > counts as a precedent, but IMO it's a more palatible fix than the > SCN/PRI ugliness. With all apologies to Churchill, SCN/PRI are the worst way to address this in a machine-independent way, except for all the other ways that have been tried from time to time. :-P -Ravi (rpokala@) > -- Ian