From owner-cvs-src@FreeBSD.ORG Fri Jun 10 17:10:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2286316A41C; Fri, 10 Jun 2005 17:10:48 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1D2C43D1D; Fri, 10 Jun 2005 17:10:47 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5AHAlo9020391; Fri, 10 Jun 2005 10:10:47 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5AHAlxV020390; Fri, 10 Jun 2005 10:10:47 -0700 Date: Fri, 10 Jun 2005 10:10:47 -0700 From: Brooks Davis To: Poul-Henning Kamp Message-ID: <20050610171047.GC17120@odin.ac.hmc.edu> References: <200506101649.j5AGnOPu077043@repoman.freebsd.org> <1397.1118423035@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: <1397.1118423035@critter.freebsd.dk> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 ifnet.9 src/sys/compat/ndis kern_ndis.c subr_ndis.c src/sys/contrib/altq/altq altq_rio.c src/sys/contrib/dev/oltr if_oltr.c if_oltr_pci.c if_oltrvar.h src/sys/contrib/pf/net if_pflog.c if_pflog.h if_pfsync.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 17:10:48 -0000 --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2005 at 07:03:55PM +0200, Poul-Henning Kamp wrote: > In message <200506101649.j5AGnOPu077043@repoman.freebsd.org>, Brooks Davi= s writ > es: >=20 > > Log: > > Stop embedding struct ifnet at the top of driver softcs. [...] > > =20 > > This change removes the size of these structures from the kernel ABI a= nd > > will allow us to better manage them as interfaces come and go. > > =20 > > Other changes of note: > > - Struct arpcom is no longer referenced in normal interface code. > > Instead the Ethernet address is accessed via the IFP2ENADDR() macro. >=20 > If this is a macro, don't you still encode, if not the size at least > part of the layout in the kernel ABI ? Yes, the layout of existing variables in struct arpcom is still part of the ABI as the existance of the ethernet address there. I decided to defer complete removal for 7.0. Keeping two copies (aprcom and LLADDR) is lame, but not a huge problem. The big issue here was to get the storage and allocation out of the hands of the driver. Getting the ethernet address access into a macro was mostly a convenient side effect that will ease further API cleanups at a later date. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCqcmWXY6L6fI4GtQRAms1AKDashlLS74avVLdNNjgyIE/wQhcCQCfe+rs qYcA/ELIRR1rBI+CpivcgVk= =glce -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--