From owner-svn-src-user@FreeBSD.ORG  Tue Apr 30 21:36:53 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 550BE5BF;
 Tue, 30 Apr 2013 21:36:53 +0000 (UTC)
 (envelope-from crees@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 484BF1A6F;
 Tue, 30 Apr 2013 21:36:53 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r3ULaqZD015210;
 Tue, 30 Apr 2013 21:36:52 GMT (envelope-from crees@svn.freebsd.org)
Received: (from crees@localhost)
 by svn.freebsd.org (8.14.6/8.14.5/Submit) id r3ULaqWx015209;
 Tue, 30 Apr 2013 21:36:52 GMT (envelope-from crees@svn.freebsd.org)
Message-Id: <201304302136.r3ULaqWx015209@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Tue, 30 Apr 2013 21:36:52 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: svn commit: r250120 - user/crees/rclint
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2013 21:36:53 -0000

Author: crees (ports committer)
Date: Tue Apr 30 21:36:52 2013
New Revision: 250120
URL: http://svnweb.freebsd.org/changeset/base/250120

Log:
  Add configfile to recommended 'clobberers'.
  
  Don't complain about quoting if %% substitution is used; there may be spaces in
  the substitution.

Modified:
  user/crees/rclint/rclint.py

Modified: user/crees/rclint/rclint.py
==============================================================================
--- user/crees/rclint/rclint.py	Tue Apr 30 20:53:28 2013	(r250119)
+++ user/crees/rclint/rclint.py	Tue Apr 30 21:36:52 2013	(r250120)
@@ -113,7 +113,7 @@ class Statement:
         if not self.quoted():
             return False
         for char in self.value[1:-1]:
-            if char in ' \t|&;<>()$`\\\"\'':
+            if char in ' \t|%&;<>()$`\\\"\'':
                 return False
         return True
 
@@ -270,7 +270,8 @@ def do_ports_checking(lineobj, filename)
     logging.debug('Checking for defaults clobbering blank values')
     for var in lineobj['Variable']:
         if var.type in ('longhand', 'shorthand'):
-            if var.name.split('_')[-1] not in ('enable', 'user', 'group') and var.clobber:
+            if var.name.split('_')[-1] not in ('enable', 'user', 'group',
+                                                'configfile') and var.clobber:
                 error.give('variables_defaults_non_mandatory_colon', var.line)
             elif not var.clobber and var.name.split('_')[-1] in ('enable'):
                 error.give('variables_defaults_mandatory_colon', var.line)