From owner-cvs-all Tue May 14 19: 1:10 2002 Delivered-To: cvs-all@freebsd.org Received: from evilpete.dyndns.org (12-232-26-46.client.attbi.com [12.232.26.46]) by hub.freebsd.org (Postfix) with ESMTP id 0F4DE37B401; Tue, 14 May 2002 19:01:06 -0700 (PDT) Received: from overcee.wemm.org ([10.0.0.3]) by evilpete.dyndns.org (8.11.6/8.11.6) with ESMTP id g4F210J09050; Tue, 14 May 2002 19:01:01 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 48ED1380F; Tue, 14 May 2002 19:01:00 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Peter Jeremy , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c In-Reply-To: Date: Tue, 14 May 2002 19:01:00 -0700 From: Peter Wemm Message-Id: <20020515020100.48ED1380F@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin wrote: > > On 14-May-2002 Peter Jeremy wrote: > > On 2002-May-11 14:49:39 -0700, Peter Wemm wrote: > >> Save about 60 bytes by #define memcpy __builtin_memcpy and removing > >> the function we provided. Restore the Keyboard: yes/no printf for the > >> probe diagnostics. We end up with 40 bytes free. > > > > More potential savings: > > - Change dev_nm definition to "const char dev_nm[4][] = ..." saves 7 bytes. > > This amounts to saving 20 bytes of pointers, but the code bloats by > > 13 bytes because of reversion from register-indirect to direct addressing > > of dev_nm in several places. (Using [3] instead of [4] actually makes > > things worse because *3 isn't possible in the R/I/M byte). > > - Change dev_maj defn to "const unsigned char dev_maj[]" saves 15 bytes. > > These and other changes suggested sound good to me. No objections from me if > you commit them. IMHO, as long as it works, go right ahead. :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message