From owner-freebsd-geom@FreeBSD.ORG Wed Mar 7 16:50:08 2007 Return-Path: X-Original-To: freebsd-geom@hub.freebsd.org Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6224B16A400 for ; Wed, 7 Mar 2007 16:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 4936413C4AA for ; Wed, 7 Mar 2007 16:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l27Go77t006942 for ; Wed, 7 Mar 2007 16:50:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l27Go7Rf006941; Wed, 7 Mar 2007 16:50:07 GMT (envelope-from gnats) Date: Wed, 7 Mar 2007 16:50:07 GMT Message-Id: <200703071650.l27Go7Rf006941@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Dennis Berger Cc: Subject: Re: kern/104389: [geom] [patch] sys/geom/geom_dump.c doesn't encode XML entities X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dennis Berger List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2007 16:50:08 -0000 The following reply was made to PR kern/104389; it has been noted by GNATS. From: Dennis Berger To: doug steinwand Cc: bug-followup@FreeBSD.org, freebsd-geom@freebsd.org Subject: Re: kern/104389: [geom] [patch] sys/geom/geom_dump.c doesn't encode XML entities Date: Wed, 07 Mar 2007 17:29:36 +0100 Yes I found this version much better than the one before. regards, -Dennis doug steinwand schrieb: > * Dennis Berger [2007-03-06 16:53:44 +0100]: > >> This way we can escape all illegal characters. >> What do you suggest? >> > > The gstat and other geom applications basically use expat to parse > the equivalent of "sysctl -b kern.geom.confxml". This output does > not have an encoding specified, so expat accepts only ASCII. As > such, bytes greater than 0x7e must be encoded. > > http://skew.org/xml/tutorial/ > http://www.w3.org/TR/1998/REC-xml-19980210 > > Attached is a patch which attempts to output valid XML for all cases > (any value between 0x00 and 0xff). One issue is that many bytes > between 0x00 and 0x1f have no valid XML coding, so this patch > replaces them with '?' (such things should not appear in geom names, > though). > > Also, it seems that expat is attempting to convert bytes from > iso-8859-1 into utf8 characters, so gstat and glabel output may > look weird. > > - doug > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-geom@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" -- Dennis Berger BSDSystems Eduardstrasse 43b 20257 Hamburg Phone: +49 (0)40 54 00 18 17 Mobile: +49 (0) 179 123 15 09 E-Mail: db@bsdsystems.de