From nobody Tue May 30 17:20:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QVzgR5bCGz4XrZP; Tue, 30 May 2023 17:20:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QVzgR578Bz3kTD; Tue, 30 May 2023 17:20:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685467235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=90BhiXDnVc2SB7A/ISeHIxdH+PpsX9Gn8Iu+HHwSPXw=; b=buM1NzNCwG0FvJP458l5oqVpCTG47yGxbNfmsNdDKJutZ9sScVCq6aXhPideVwuqOaHI3J GoVT5jpQ1iBbaSkyrEd6MzuBJJP3OBvGWq6soaqLD3q0qB3s4DH9sPnjv5iplF+8gAb5ZL b9m4UUoADKzTIAxPByFXhEtR4+Fm7BVVyD/OWAE6fZpWWvFvFDCkIrWIWtMhtP84Eh5GMs 7KdVVv6IyNuM3QHzLe6apeQeo6YItb7LwFgI0MFwCqiMXgHChGM9kHOgYhg1XF9PxP5V6m nyMnjMEQL21sQQd6tu0Zpkp86OtSW1vPHhGN8SXMMgEXrxx48Lo1fzf16KMWxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685467235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=90BhiXDnVc2SB7A/ISeHIxdH+PpsX9Gn8Iu+HHwSPXw=; b=l8FisMUu72uDNAgufqDRiH6YGej2IdJ+0hN6NanoqIJ3S8LaxWopGcsng8Fgp6xDPZeEK+ PcmPnxBCLowe+bWcnJdLNRDvGqJbc2fYEle8bbKCWSgcSKHjLLO4VdBDSPhzZ7o46s319Y e/mnBlpiG2yejR9hBCxHT+iCIRzFR10XvuQReKQEk+Tct2m7UKoT1D1Xj65vjG4Erw+nbq j2umOB2SlJIlKdJk9SkjQVP4qMf2ERUvUFCf3+bgQevRZeWwKoXSj1iWXPqFW84xyz7wP0 NopO+u23SuO0+bvgBfOcKIiFl+Fev3uFZvd+/xBFRylJ928PGKdF5DSjpj+ekg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685467235; a=rsa-sha256; cv=none; b=Yjm7YDbGelkX7BgkpA5EZ2b1G71pGCgfz7lo+5d6x3emhTi6dUBXDHsJkj26YH2SF6oYTO ED6jdpD6OStznO/pG1A/0ucKS5uw8B0wOwCeYU9QAB4zoo9Xe+jCmYL6fGvmtDH6+l5NT+ 1W4oaqPn1fRiT+iW1QV5d/ypQBnBgmic30xEkrNrsJE4yBXevhEuhpJLPyjiVqREr2JDe+ Moyvwwi0Iyqrushe62iOfwFP7SpsJbtXKxAaFow05aXAUcCe3UbKiqp7tTh4VX9pngK8yx YgHGvG3eFwXR+mdv0c+bsabb2B9SS9ldvmBojEtltZf59Grs7/BCmOXT+ZXJAg== Received: from [IPV6:2601:648:8680:16b0:b998:2010:344a:9cf2] (unknown [IPv6:2601:648:8680:16b0:b998:2010:344a:9cf2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QVzgR0XRXzk2t; Tue, 30 May 2023 17:20:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0764bffa-f3e4-3619-fb57-856db2fcb4cd@FreeBSD.org> Date: Tue, 30 May 2023 10:20:33 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Dmitry Chagin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202305300819.34U8JrK1039933@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: 4f2c2a122c6f - main - avx_sig: Adapt avx_sig test for Aarch64 In-Reply-To: <202305300819.34U8JrK1039933@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 5/30/23 1:19 AM, Dmitry Chagin wrote: > The branch main has been updated by dchagin: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > > commit 4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > Author: Dmitry Chagin > AuthorDate: 2023-05-30 08:19:40 +0000 > Commit: Dmitry Chagin > CommitDate: 2023-05-30 08:19:40 +0000 > > avx_sig: Adapt avx_sig test for Aarch64 > > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D40309 The comment at the top of avx_sig.c still references AVX and %xmm FWIW and needs updating. (The fact that it is also only testing xmm makes it an SSE test on x86 and not an AVX test anyway) Can we also rename this tool now as avx_sig isn't a very intuitive name for an aarch64 test? Maybe call it simd_sig given your earlier changes? I'm also not quite sure what the 'c2x2c' part of the filename means for the MD files? The functions it defines are 'cpu_to_simd' and 'simd_to_cpu', so maybe just 'simd_.S' makes more sense? (And you could also perhaps use MACHINE_CPUARCH in SRCS to require fewer .if's in the Makefile) -- John Baldwin