From owner-svn-src-head@freebsd.org Fri Oct 27 15:37:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41C0BE4950F for ; Fri, 27 Oct 2017 15:37:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0147A6B9C1 for ; Fri, 27 Oct 2017 15:37:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x243.google.com with SMTP id h70so13559221ioi.4 for ; Fri, 27 Oct 2017 08:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0O8rXskDNCcW9ILI7UihRlvqoW84ahFW1WkA2ShJEzQ=; b=zvhmd4PEUQcPnRDeenlXmFVqcss4OoEtlvXOtiwIaQaTn5uEvTmZ6uXiLVFDXhPzWt 87JA9pEhBO7ESqkfGpORQaS8Thj2Lz02zcw9kx9uX77aJIUTyXhC30FtLo0B2nkwHK2f /JylP0ZT24UOfLdOxXiwEAY3kOyjCN7n9vczlj7ug1U4hnLfNHtFq0xsgCsvys/ZQTKE tnBlHAcr6EwS6jtWzwVU1DZpYw0l+oq6NuC4+w5XboHRIcFd3h3HsPfCcjXTrbdRfNzl LL84nOMdWQUM18os1eW5tpEVjpRcnPGQseAk/YPj7K81oQlexGzcqzXrrPTAhs4CL5me 8d7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0O8rXskDNCcW9ILI7UihRlvqoW84ahFW1WkA2ShJEzQ=; b=fSO7yJ/GUEL4CDFAgHlyB+R4aV1nIwOsSYUj7k9Y6VAewjL9DM/4DMmilfY6JMpqjH d5LmuqKxMOg++g6NjZUR4wpzziYUygWTr6hmNlV8uwMv5gWnuVkElZF0JMzWMDOEmwQI gldBbV/NwtQ09seuix90j3f6D7VFqcvojfw/bBJAokV2ngi6vtODq3/KL6KGbPmg0sJR YTz7UTj7Rh6CTXuDhqL0MY3eWZYi7vyv2Sr6Pfv56ad3eO9MeAfwG7w9F6IBXeImarfY Bbq82PnfQJVUQo++SnmYSD5h+4b05v5DYEBbUoAAD5nip+NqAXuMdyaDdju2war7cCfx waJw== X-Gm-Message-State: AMCzsaUqBV5P+VfDj3SZiLPHhdSb+TzyIjYZvk0tKNE6UuOi9EPDoNao 22UzcUK8+5pTNSdW9oWud0jI1PfmaGaAKkVEDijd2w== X-Google-Smtp-Source: ABhQp+SCkUFuDsZUR8SAywXNIn1gvvSFoF4Zjim1Mm16m6pJ49rGr7GivxnRxGGrR768/LcDnrnw++lDSN8UJmBaPZg= X-Received: by 10.107.27.7 with SMTP id b7mr1081301iob.136.1509118649286; Fri, 27 Oct 2017 08:37:29 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Fri, 27 Oct 2017 08:37:27 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:68f3:90da:7630:94a5] In-Reply-To: References: <201710271457.v9REvcNr006595@repo.freebsd.org> From: Warner Losh Date: Fri, 27 Oct 2017 09:37:27 -0600 X-Google-Sender-Auth: y3m0zUpBmBERZxkChHvwsnJUyJ0 Message-ID: Subject: Re: svn commit: r325040 - head/sys/cam/nvme To: Alan Somers Cc: Warner Losh , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 15:37:30 -0000 On Fri, Oct 27, 2017 at 9:05 AM, Alan Somers wrote: > On Fri, Oct 27, 2017 at 8:57 AM, Warner Losh wrote: > > Author: imp > > Date: Fri Oct 27 14:57:38 2017 > > New Revision: 325040 > > URL: https://svnweb.freebsd.org/changeset/base/325040 > > > > Log: > > nvd alias has caused some problems, revert it for the moment. > > > > Sponsored by: Netflix > > > > Modified: > > head/sys/cam/nvme/nvme_da.c > > > > Modified: head/sys/cam/nvme/nvme_da.c > > ============================================================ > ================== > > --- head/sys/cam/nvme/nvme_da.c Fri Oct 27 14:57:14 2017 (r325039) > > +++ head/sys/cam/nvme/nvme_da.c Fri Oct 27 14:57:38 2017 (r325040) > > @@ -794,7 +794,7 @@ ndaregister(struct cam_periph *periph, void *arg) > > /* > > * Add alias for older nvd drives to ease transition. > > */ > > - disk_add_alias(disk, "nvd"); > > + /* disk_add_alias(disk, "nvd"); Have reports of this causing > problems */ > > > > /* > > * Acquire a reference to the periph before we register with > GEOM. > > Is there a PR? If so, please link the PR from the comment. > No PR. We had a problem at Netflix with the multiple drives we have in a system, so we disabled it locally. I wasn't seeing it in !Netflix FreeBSD at the time, so I didn't upstream. I since discovered the problem on a raw FreeBSD kernel on my machines here, but haven't had time to investigate further. It could be multiple drives, or something else triggering it. I just don't know yet, so there's nothing concrete to point to. Warner