From owner-p4-projects  Thu Jun 20  1: 4:12 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3C65E37B40C; Thu, 20 Jun 2002 01:04:03 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from overcee.wemm.org (12-232-114-102.client.attbi.com [12.232.114.102])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5B83C37B40A; Thu, 20 Jun 2002 01:04:02 -0700 (PDT)
Received: from wemm.org (localhost [127.0.0.1])
	by overcee.wemm.org (Postfix) with ESMTP
	id 58285380E; Thu, 20 Jun 2002 01:04:04 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: Julian Elischer <julian@elischer.org>
Cc: Jake Burkholder <jake@locore.ca>,
	Julian Elischer <julian@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 12762 for review 
In-Reply-To: <Pine.BSF.4.21.0206121317520.90133-100000@InterJet.elischer.org> 
Date: Thu, 20 Jun 2002 01:04:04 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20020620080404.58285380E@overcee.wemm.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

Julian Elischer wrote:
> ok, thanks. 
> I'll (re)fix them.

Good, bde will tell you off otherwise. :-)  This is as much a syntax error
as the original code according to strict interpretation of the C standard.

> On Wed, 12 Jun 2002, Jake Burkholder wrote:
> 
> > Apparently, On Wed, Jun 12, 2002 at 12:21:42PM -0700,
> > 	Julian Elischer said words to the effect of;
> > 
> > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12762
> > > 
> > > Change 12762 by julian@julian_ref on 2002/06/12 12:21:09
> > > 
> > > 	fix warning
> > 
> > FYI, the preferred way to fix these is to put a break instead
> > of a null statement.
> > 
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/projects/kse/sys/vm/vm_meter.c#13 edit
> > > 
> > > Differences ...
> > > 
> > > ==== //depot/projects/kse/sys/vm/vm_meter.c#13 (text+ko) ====
> > > 
> > > @@ -149,6 +149,7 @@
> > >  					totalp->t_sl++;
> > >  					continue;
> > >  				default:
> > > +					;
> > >  				}
> > >  			}
> > >  		}
> > 
> 
> 

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message