From owner-freebsd-gnome@FreeBSD.ORG Wed May 2 06:24:55 2007 Return-Path: X-Original-To: gnome@FreeBSD.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 61AAA16A402 for ; Wed, 2 May 2007 06:24:55 +0000 (UTC) (envelope-from brians@ca.sophos.com) Received: from lightroast.ca.sophos.com (gw.ca.sophos.com [209.17.183.249]) by mx1.freebsd.org (Postfix) with ESMTP id 2B6B513C45A for ; Wed, 2 May 2007 06:24:54 +0000 (UTC) (envelope-from brians@ca.sophos.com) Received: from smtp3.ca.sophos.com (smtp3.ca.sophos.com [192.168.3.19]) by lightroast.ca.sophos.com (8.13.8/8.13.8) with ESMTP id l426Oncp017104 for ; Tue, 1 May 2007 23:24:49 -0700 (PDT) (envelope-from brians@ca.sophos.com) Received: from dev.lan.Awfulhak.org (ssh1.ActiveState.com [192.168.3.32]) by smtp3.ActiveState.com (8.13.4/8.13.4) with ESMTP id l426Om1t013659; Tue, 1 May 2007 23:24:48 -0700 (envelope-from brians@ca.sophos.com) Date: Tue, 1 May 2007 23:24:48 -0700 From: Brian Somers To: Brian Somers Message-ID: <20070501232448.1239bbd3@dev.lan.Awfulhak.org> In-Reply-To: <20070501123616.6b43b4de@conflict.ca.sophos.com> References: <20070501123616.6b43b4de@conflict.ca.sophos.com> Organization: Sophos X-Mailer: Claws Mail 2.8.1 (GTK+ 2.10.11; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-PerlMx-Spam: CA, All, Gauge=IIIIIII, Probability=7%, Report='__C230066_P5 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0' X-SpamReport: No antispam rules were triggered by this message Cc: gnome@FreeBSD.org Subject: Re: Fix for x11/gnome-screensaver X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 06:24:55 -0000 On Tue, 1 May 2007 12:36:16 -0700 Brian Somers wrote: > Hi, > > Could someone apply the attached patch for x11/gnome-screensaver > or approve it for me to commit? > > TIA. > > -- > Brian Somers Tel: +1 604 484 6434 > Mob: +1 604 315 1343 > Sophos - security and control Web: www.sophos.com > > Index: Makefile > =================================================================== > RCS file: /usr/home/ncvs/ports/x11/gnome-screensaver/Makefile,v > retrieving revision 1.23 > diff -u -r1.23 Makefile > --- Makefile 11 Apr 2007 13:32:59 -0000 1.23 > +++ Makefile 1 May 2007 19:34:17 -0000 > @@ -47,7 +47,7 @@ > CONFIGURE_ARGS+= --disable-pam > .endif > > -pre-install: > +pre-su-install: > @${CP} ${.CURDIR}/pkg-plist ${PLIST} > @cd ${XSCREENSAVER_DIR} && ${FIND} -s * -maxdepth 1 -type f -name "*.xml" | \ > ${GREP} -Ev ${XSCREENSAVER_EXCLUDE} | \ > @@ -55,7 +55,7 @@ > ${SED} -e 's:[.]xml$$:.desktop:' >> ${PLIST} > @${ECHO_CMD} @dirrm ${SCREENSAVER_DIR} >> ${PLIST} > > -post-install: > +post-su-install: > ${CHOWN} root ${PREFIX}/libexec/gnome-screensaver-dialog > ${CHMOD} +s ${PREFIX}/libexec/gnome-screensaver-dialog > ${MKDIR} ${PREFIX}/${SCREENSAVER_DIR} Hmm, it seems that post-su-install doesn't exist and post-install is run with root credentials, so please disregard the second part of the patch. The pre-install -> pre-su-install change is still required though... Cheers. -- Brian Somers Tel: +1 604 484 6434 Mob: +1 604 315 1343 Sophos - security and control Web: www.sophos.com