From owner-freebsd-ports@freebsd.org Mon Dec 31 02:15:32 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12A5B1419F42 for ; Mon, 31 Dec 2018 02:15:32 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc31.google.com (mail-yw1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0059480AFF for ; Mon, 31 Dec 2018 02:15:30 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc31.google.com with SMTP id b63so8894056ywc.11 for ; Sun, 30 Dec 2018 18:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xN79Jhuv/dM5vNFMbLtQKyg4lJ9dDb5HBAE6+2jDdEo=; b=yhgo1DMO/9ufVHXrLGnx+QjspTOxmDf/79B0cxbWBAdaaOZON7dKvpZIUqAvBr1C6i miZZTCggG3P+83oiiK8w4leYANpnHy515ZUkqC3iT9VOZYOL/1T5N+oZRmOHNbkdjOfy c8IAFeGZ3KPbTA4hxaXJ6vl1NiChFuR/vcbAMGWqgmsUywgkCUtW8sptQwP16Igyvme7 MA5vk3jKq7HQ5f5JXl9mqQCDP/4QMd72NiAOeZPQnsYBhIf7/IST3fv7nnJtnHq+Ez6z /zQ5pi8Bzg5xh1w35ileTDCDaQ/VXvHlRq4t0HoX66jf9VUizdWUWfJLPNfqO7oWL4gj Y8vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xN79Jhuv/dM5vNFMbLtQKyg4lJ9dDb5HBAE6+2jDdEo=; b=pnMY5sS66i3qOa1ayw+eIdj2IUVOHOzVXLJW5hJ75xTp0vwRs/Dhh7TYXkjbJHuG8h nuhulKM2NDlzQ8oYr7rJlEb3/lNj1Lo4uPjo7ig0ba8p20IrgLbQ9GKk61v9XJfnFmDf Id9/DjZl7uyIrmB6Z4HFKbaaDGhzbJDP5WcHzCdl/x0YADL3i3eZEt8zR6OUS6/tJYXc jZ1vU+LlxeRPCA0KavSeD69vY83b6nomV52fnHdrNOU+i9eUAoSm587w3UF4SV0yCtOe vFHHWlvo/+spD0KO/SyYMxTgWtxGfb84CdTripZofrXfKu1h5CYNtpSrCcdXs26hjHay Lncg== X-Gm-Message-State: AA+aEWZAFoqqkojUwZE4tgYf+k+w/bCZtaxI1wkz4WtQ1MVLd8o7TxB0 fJCUaOKOE+E7vv1SjapjlZxiZmtntXT9Mue0q3O3udCUdyo= X-Google-Smtp-Source: AFSGD/WINPBzXhPFCoqnTjGETG/bF1g6SEkgNmtxv3Oc865ZJXt9EyrJFegsG4GO947drKZ1IN4HJ6W+Ii9VCZ3qYJk= X-Received: by 2002:a81:31d5:: with SMTP id x204mr36871294ywx.141.1546222529965; Sun, 30 Dec 2018 18:15:29 -0800 (PST) MIME-Version: 1.0 References: <20181229.134412.1093009159948437947.yasu@utahime.org> <20181230.103514.1004952746059751135.yasu@utahime.org> <087f33fc-69b8-a4a1-a23e-e7c74af960f9@nomadlogic.org> In-Reply-To: From: Adam Weinberger Date: Sun, 30 Dec 2018 19:15:14 -0700 Message-ID: Subject: Re: Request for help: remove bundler from ruby 2.6 port To: Pete Wright Cc: Yasuhiro KIMURA , freebsd-ports@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0059480AFF X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=yhgo1DMO; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2607:f8b0:4864:20::c31 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.21 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; DMARC_NA(0.00)[adamw.org]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.00)[0.005,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: alt1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[1.3.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.71)[ipnet: 2607:f8b0::/32(-1.91), asn: 15169(-1.54), country: US(-0.08)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2018 02:15:32 -0000 On Sun, Dec 30, 2018 at 6:00 PM Pete Wright wrote: > > > > On 12/30/18 4:31 PM, Adam Weinberger wrote: > > On Sun, Dec 30, 2018 at 5:27 PM Pete Wright wrote: > >> > >> > >> On 12/29/18 5:35 PM, Yasuhiro KIMURA wrote: > >>> From: Adam Weinberger > >>> Subject: Re: Request for help: remove bundler from ruby 2.6 port > >>> Date: Sat, 29 Dec 2018 15:34:17 -0700 > >>> > >>>> I think perhaps it's worth considering doing the opposite and, > >>>> beginning with 2.6, install the entire standard library by default. > >>>> Gems and stdlib exist side-by-side without problem, and many of the > >>>> gems that are deleted are generally kept up-to-date. > >>>> > >>>> Even if we don't want to install the entire standard library, I'd at > >>>> least strongly argue for including the most important gems (rake, gem, > >>>> minitest, and bundler) by default. They are basic components of ruby > >>>> itself, and ports should provide //optional// newer versions of them. > >>> From: Pete Wright > >>> Subject: Re: Request for help: remove bundler from ruby 2.6 port > >>> Date: Sat, 29 Dec 2018 16:41:32 -0800 > >>> > >>>> +1 from me on this. > >>>> > >>>> i think the benefits of lowering the porting overhead combined with > >>>> the fact that most ruby envs i've supported (and currently support) > >>>> are built around the expectation that rake, gem and bundler are all > >>>> available - so this would lower my administrative overhead as well. > >>> Thank you for reply. Then I'm going to create full port and post here > >>> again. But I'm away from this evening to next Saturday and can't > >>> access development environment during that time. So if someone else > >>> want to try it, please don't hesitate. > >> I was able to build this on 13-CURRENT/amd64 today without issues. the > >> ruby26 runtime seems OK after initial testing, but there is an issue > >> with bundler26: > >> > >> $ /usr/local/bin/bundle26 > >> Traceback (most recent call last): > >> 2: from /usr/local/bin/bundle26:23:in `
' > >> 1: from /usr/local/lib/ruby/2.6/rubygems.rb:302:in `activate_bin_path' > >> /usr/local/lib/ruby/2.6/rubygems.rb:283:in `find_spec_for_exe': can't > >> find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException) > >> > >> > >> i did verify that this package does not conflict with the existing > >> rubygem-bundler and ruby24 ports. > >> > >> as a starting place I have created this PR: > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234509 > >> > >> if i have time over the next couple days i'll take a closer look at how > >> bundler is being built and see if can fix the above issue. > > Bundler's whole purpose is to install gems using the 'gem' command, > > which the ruby port specifically excludes. So, all the Bundler stuff > > will have to be removed for the ruby26 port. Take a look at the > > Makefile where we delete all the rake-related stuff; Bundler should be > > removed in the same way. > oh i see. so dumb question, but it looks like rubygem-bundler depends > on ruby24 and it's gems package. > > $ sudo pkg install rubygem-bundler > > New packages to be INSTALLED: > rubygem-bundler: 1.17.1 [FreeBSD] > ruby: 2.4.5_1,1 [FreeBSD] > ruby24-gems: 2.7.8 [FreeBSD] > > > what is the proper way to get bundler to support 2.5 and 2.6? Ruby selection is determined by DEFAULT_VERSIONS. In your /etc/make.conf, put: DEFAULT_VERSIONS+= ruby=2.5 # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org