From owner-svn-src-all@FreeBSD.ORG  Wed Oct 17 18:46:13 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 91E62C5;
 Wed, 17 Oct 2012 18:46:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 612AE8FC18;
 Wed, 17 Oct 2012 18:46:13 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 811D3B9A3;
 Wed, 17 Oct 2012 14:46:12 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Maksim Yevmenkin <emax@freebsd.org>
Subject: Re: svn commit: r241616 - in head/sys: dev/ixgbe net
Date: Wed, 17 Oct 2012 13:20:24 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; )
References: <201210162018.q9GKIG9q013028@svn.freebsd.org>
 <201210170951.23800.jhb@freebsd.org>
 <CAFPOs6rVjFqh4FxfSt_yhzUGvgiVQkmpP6Lbgyckz6X7Y96RQQ@mail.gmail.com>
In-Reply-To: <CAFPOs6rVjFqh4FxfSt_yhzUGvgiVQkmpP6Lbgyckz6X7Y96RQQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201210171320.24557.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 17 Oct 2012 14:46:12 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Oct 2012 18:46:13 -0000

On Wednesday, October 17, 2012 11:26:21 am Maksim Yevmenkin wrote:
> On Wed, Oct 17, 2012 at 6:51 AM, John Baldwin <jhb@freebsd.org> wrote:
> 
> [...]
> 
> >> > Maybe a helper 'if_set_baudrate(ifp, IF_Gbps(10))' that would DTRT.
> >> > (It could be a static inline or some such).  I would just like to
> >> > keep the readability.
> >>
> >> well, yes, i thought about it, but decided not to do it right away. we
> >> could provide shortcuts/macros for "popular" baudrates, i.e. 1, 10, 40
> >> and 100 Gbps. while ixgbe(4) example is not ideal, i thought it still
> >> was pretty readable :)
> >
> > I don't really find it all that readable.  IF_Gbps(1) looks like a typo
> > to a casual reader.  I really think you should have something like:
> 
> [...]
> 
> very well :)  would something like (please see below) work?

Looks good to me.  Thank you. :)

-- 
John Baldwin