From owner-svn-src-head@freebsd.org  Wed Mar  2 03:28:59 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 533FCAC0D64;
 Wed,  2 Mar 2016 03:28:59 +0000 (UTC) (envelope-from cy@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 24B36121F;
 Wed,  2 Mar 2016 03:28:59 +0000 (UTC) (envelope-from cy@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u223SwKr036268;
 Wed, 2 Mar 2016 03:28:58 GMT (envelope-from cy@FreeBSD.org)
Received: (from cy@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u223SwLU036267;
 Wed, 2 Mar 2016 03:28:58 GMT (envelope-from cy@FreeBSD.org)
Message-Id: <201603020328.u223SwLU036267@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: cy set sender to cy@FreeBSD.org
 using -f
From: Cy Schubert <cy@FreeBSD.org>
Date: Wed, 2 Mar 2016 03:28:58 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r296299 - head/sys/contrib/ipfilter/netinet
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 03:28:59 -0000

Author: cy
Date: Wed Mar  2 03:28:57 2016
New Revision: 296299
URL: https://svnweb.freebsd.org/changeset/base/296299

Log:
  Remove redundant NULL pointer comparison.
  
  Reported  by:		PVS-Studio (V595) in D5245
  Differential Revision:	D5245

Modified:
  head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c

Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c
==============================================================================
--- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c	Wed Mar  2 03:26:56 2016	(r296298)
+++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c	Wed Mar  2 03:28:57 2016	(r296299)
@@ -1951,10 +1951,6 @@ ipf_p_ftp_epsv(softf, fin, ip, nat, ftp,
 		ap += *s++ - '0';
 	}
 
-	if (!s) {
-		return 0;
-}
-
 	if (*s == '|')
 		s++;
 	if (*s == ')')