From owner-svn-src-head@FreeBSD.ORG  Thu Sep  2 22:18:05 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B239910657E0;
	Thu,  2 Sep 2010 22:18:05 +0000 (UTC)
	(envelope-from gibbs@FreeBSD.org)
Received: from aslan.scsiguy.com (aslan.scsiguy.com [70.89.174.89])
	by mx1.freebsd.org (Postfix) with ESMTP id 72D538FC1C;
	Thu,  2 Sep 2010 22:18:05 +0000 (UTC)
Received: from [192.168.4.137] (207-225-98-3.dia.static.qwest.net
	[207.225.98.3]) (authenticated bits=0)
	by aslan.scsiguy.com (8.14.4/8.14.4) with ESMTP id o82M7eJA004236
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Thu, 2 Sep 2010 16:07:42 -0600 (MDT)
	(envelope-from gibbs@FreeBSD.org)
Message-ID: <4C802028.4040400@FreeBSD.org>
Date: Thu, 02 Sep 2010 16:07:36 -0600
From: "Justin T. Gibbs" <gibbs@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
	rv:1.9.2.9) Gecko/20100825 Thunderbird/3.1.3
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <201009021940.o82JeS8M017537@svn.freebsd.org>
	<20100902213926.GA2542@garage.freebsd.pl>
In-Reply-To: <20100902213926.GA2542@garage.freebsd.pl>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r212160 - in head/sys: cam/ata cam/scsi
 cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: gibbs@FreeBSD.org
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Sep 2010 22:18:05 -0000

 On 9/2/2010 3:39 PM, Pawel Jakub Dawidek wrote:
> On Thu, Sep 02, 2010 at 07:40:28PM +0000, Justin T. Gibbs wrote:
>> Author: gibbs
>> Date: Thu Sep 2 19:40:28 2010
>> New Revision: 212160
>> URL: http://svn.freebsd.org/changeset/base/212160
>>
>> Log:
>> Correct bioq_disksort so that bioq_insert_tail() offers barrier semantic.

...

>> sys/geom/geom_io.c
>> Mark bios with the BIO_FLUSH command as BIO_ORDERED.
> [...]
>
> Don't you think it would be better to set the flag from within
> g_io_request()? This way every BIO_FLUSH consumer doesn't have to
> remember to set it. Or am I missing something?

I don't feel strongly one way or the other, but I thought that
g_io_request()'s job was to execute the request and to test invariants,
not to set policy.  Perhaps I misinterpreted it's role.

--
Justin