Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Jun 2024 22:36:09 GMT
From:      Vladimir Druzenko <vvd@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 411ad89a8344 - main - java/apache-commons-collections: limit JAVA_VERSION from 8 to 20 because build fails with 21+
Message-ID:  <202406092236.459Ma9Wm031364@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by vvd:

URL: https://cgit.FreeBSD.org/ports/commit/?id=411ad89a8344407c361b653509a3a598204f1ae8

commit 411ad89a8344407c361b653509a3a598204f1ae8
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-09 22:27:04 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-09 22:27:04 +0000

    java/apache-commons-collections: limit JAVA_VERSION from 8 to 20 because build fails with 21+
    
    Build error with OpenJDK 21:
        [javac] /wrkdirs/usr/ports/java/apache-commons-collections/work/commons-collections-3.2.2-src/src/java/org/apache/commons/collections/CursorableLinkedList.java:188: error: addLast(Object) in CursorableLinkedList cannot implement addLast(E) in List
        [javac]     public boolean addLast(Object o) {
        [javac]                    ^
        [javac]   return type boolean is not compatible with void
        [javac]   where E is a type-variable:
        [javac]     E extends Object declared in interface List
        [javac] /wrkdirs/usr/ports/java/apache-commons-collections/work/commons-collections-3.2.2-src/src/java/org/apache/commons/collections/CursorableLinkedList.java:176: error: addFirst(Object) in CursorableLinkedList cannot implement addFirst(E) in List
        [javac]     public boolean addFirst(Object o) {
        [javac]                    ^
        [javac]   return type boolean is not compatible with void
        [javac]   where E is a type-variable:
        [javac]     E extends Object declared in interface List
    
    New JDK 21 methods in java.util.List addFirst and addLast has a void
    return type. This clashes with the existing boolean return from the
    same method in AbstractLinkedList.
    Upstream fixed this in 4.5.0 only. But this old 3.x branch isn't fixed.
    Upstream issue: https://issues.apache.org/jira/browse/COLLECTIONS-842
    
    PR:             279425
    Reported by:    antoine (exp-run)
---
 java/apache-commons-collections/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/apache-commons-collections/Makefile b/java/apache-commons-collections/Makefile
index 6c52ce1209f7..bf861617ee20 100644
--- a/java/apache-commons-collections/Makefile
+++ b/java/apache-commons-collections/Makefile
@@ -13,7 +13,7 @@ LICENSE=	APACHE20
 LICENSE_FILE=	${WRKSRC}/LICENSE.txt
 
 USE_JAVA=	yes
-JAVA_VERSION=	8+
+JAVA_VERSION=	8 11 17 18 19 20
 USE_ANT=	yes
 
 ALL_TARGET=	jar



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202406092236.459Ma9Wm031364>