From owner-cvs-all@FreeBSD.ORG Sun Apr 30 01:45:11 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7986516A400; Sun, 30 Apr 2006 01:45:11 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id E860D43D46; Sun, 30 Apr 2006 01:45:10 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 7D6DF20015F; Sun, 30 Apr 2006 03:45:08 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 29782200158; Sun, 30 Apr 2006 03:45:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id A8EFB4448D6; Sun, 30 Apr 2006 01:40:55 +0000 (UTC) Date: Sun, 30 Apr 2006 01:40:55 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Maxim Sobolev In-Reply-To: <445407B0.5000000@FreeBSD.org> Message-ID: <20060430012542.B13011@maildrop.int.zabbadoz.net> References: <200604280317.k3S3Hb3L017882@repoman.freebsd.org> <1146195791.40894.6.camel@shumai.marcuscom.com> <44524F85.5000508@FreeBSD.org> <20060429081427.J13011@maildrop.int.zabbadoz.net> <445407B0.5000000@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sk if_sk.c if_skreg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Apr 2006 01:45:11 -0000 On Sat, 29 Apr 2006, Maxim Sobolev wrote: > Bjoern A. Zeeb wrote: >> On Fri, 28 Apr 2006, Maxim Sobolev wrote: >> >>> Joe Marcus Clarke wrote: >>>> On Fri, 2006-04-28 at 03:17 +0000, Maxim Sobolev wrote: >>>>> sobomax 2006-04-28 03:17:37 UTC >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: >>>>> sys/dev/sk if_sk.c if_skreg.h Log: >>>>> Add some incomplete support for Marvell Yukon EC controllers based on >>>>> OpenBSD changes. With these changes, PHY part of the driver becomes >> >> So are you going to back out your last change to sk(4)? > > Why would I? because as you said it's incomplete and doesn't really help sk and further won't help once we get myk into the tree because sk will also successfully attach and not work for those cards then. What was also said is that we do not want to add the code for the PCIe (Y-II) cards to sk but want to have a different driver. sk already has too many if() in its paths and adding different kind of hardware to the driver won't make it any better. If you have time and interest in getting the PCIe chipsets working you should have a look at the myk code posted by andre and the follow-up comments. Thanks. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT