From owner-freebsd-stable@freebsd.org Fri Oct 27 15:36:06 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 892F9E49388 for ; Fri, 27 Oct 2017 15:36:06 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 244296B817 for ; Fri, 27 Oct 2017 15:36:05 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v9RFa3OB004284 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 27 Oct 2017 11:36:03 -0400 (EDT) (envelope-from mike@sentex.net) Received: from [192.168.43.26] (saphire3.sentex.ca [192.168.43.26]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v9RFa0WW031615; Fri, 27 Oct 2017 11:36:00 -0400 (EDT) (envelope-from mike@sentex.net) Subject: Re: ppp routing bug ? To: Eugene Grosbein , FreeBSD-STABLE Mailing List References: <59F1B650.5070107@grosbein.net> <22c3cbd4-2a8e-884f-ec9b-cc4d12ff818f@sentex.net> <59F1EA48.1090500@grosbein.net> <59F206CB.5000006@grosbein.net> <98f44309-d706-4cef-c0b2-0f08e0e1855c@sentex.net> <59F25ED0.1010001@grosbein.net> From: Mike Tancsa Organization: Sentex Communications Message-ID: <639cc812-d865-15a7-eda1-cb71575dc2e6@sentex.net> Date: Fri, 27 Oct 2017 11:36:00 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <59F25ED0.1010001@grosbein.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 15:36:06 -0000 On 10/26/2017 6:16 PM, Eugene Grosbein wrote: > 27.10.2017 1:04, Mike Tancsa пишет: >> >> the borked route monitor looks like >> >> got message of size 124 on Thu Oct 26 12:21:12 2017 >> RTM_ADD: Add Route: len 124, pid: 29597, seq 2, errno 0, >> flags: >> locks: inits: >> sockaddrs: >> 192.168.134.2 64.7.128.7 >> >> >> got message of size 196 on Thu Oct 26 12:21:13 2017 >> RTM_CHANGE: Change Metrics or flags: len 196, pid: 29597, seq 5, errno >> 0, flags: >> locks: inits: >> sockaddrs: >> 192.168.134.2 64.7.128.7 tun0 98-159-244-185.agas1a-dynamic.dsl.sentex.ca > > That makes sense: ppp send bogus request to the routing socket and > the request has not RTF_HOST flag nor RTA_NETMASK address. > It seems, earlier kernel code masked this bug somehow but it does not now. > > Anyway, we have two bugs here: ppp sending bad request and kernel having > no enough checks for this somehow. > > Fixing ppp part would be easy. Please try this patch: Thanks, that seems to restore the earlier functionality! ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/