From owner-cvs-all@FreeBSD.ORG  Tue Nov  8 21:42:41 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B0B7D16A41F;
	Tue,  8 Nov 2005 21:42:41 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB4FA43D53;
	Tue,  8 Nov 2005 21:42:40 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id jA8LgcfT057210;
	Wed, 9 Nov 2005 00:42:38 +0300 (MSK)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.3/8.13.3/Submit) id jA8Lgbaa057208;
	Wed, 9 Nov 2005 00:42:38 +0300 (MSK) (envelope-from yar)
Date: Wed, 9 Nov 2005 00:42:37 +0300
From: Yar Tikhiy <yar@FreeBSD.org>
To: "Ralf S. Engelschall" <rse@FreeBSD.org>
Message-ID: <20051108214237.GB50391@comp.chem.msu.su>
References: <200511031317.jA3DHneM091119@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511031317.jA3DHneM091119@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d pf
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Nov 2005 21:42:42 -0000

On Thu, Nov 03, 2005 at 01:17:49PM +0000, Ralf S. Engelschall wrote:
> rse         2005-11-03 13:17:49 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             pf 
>   Log:
>   There is no need to explicitly add "status" to $extra_commands in
>   the /etc/rc.d/pf script as it is implicitly added by /etc/rc.subr's
>   run_rc_command() because of the existing $pf_program.
>   
>   Submitted by:   Christoph Schug <chris@schug.net>
>   MFC after:      1 week
>   
>   Revision  Changes    Path
>   1.11      +1 -1      src/etc/rc.d/pf

I'm afraid you were relying on evil side-effects of the variable being
named *_program.  Those side-effect have been eliminated since rc.subr
rev. 1.42.  Now "status" doesn't appear among rc.d/pf valid arguments:

	vpc7# sh /etc/rc.d/pf
	Usage: /etc/rc.d/pf [fast|force|one](start|stop|restart|rcvar|check|reload|resync)

I might be wrong, but it seems to me that your change to rc.d/pf
should be backed out.

The point is that the default "status" method is for rc.d scripts
that handle startup and shutdown of conventional daemons, and not
for custom tasks like the pf case.

-- 
Yar