From owner-freebsd-ports-bugs@freebsd.org Tue May 17 21:12:10 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D1C0B3F3F9 for ; Tue, 17 May 2016 21:12:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81EE01B04 for ; Tue, 17 May 2016 21:12:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u4HLCAhb041099 for ; Tue, 17 May 2016 21:12:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209590] emulators/qemu-sbruno emulators/qemu-user-static: Fix build with libc++ 3.8.0 Date: Tue, 17 May 2016 21:12:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: sbruno@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2016 21:12:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209590 Bug ID: 209590 Summary: emulators/qemu-sbruno emulators/qemu-user-static: Fix build with libc++ 3.8.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: sbruno@FreeBSD.org Reporter: dim@FreeBSD.org Flags: maintainer-feedback?(sbruno@FreeBSD.org) Assignee: sbruno@FreeBSD.org Created attachment 170418 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170418&action= =3Dedit Don't define certain atomic macros for C++ During the exp-run in bug 208158, it was found that emulators/qemu-sbruno [= 1] and emulators/qemu-user-static [2] give errors with libc++ 3.8.0: CXX disas/arm-a64.o In file included from disas/arm-a64.cc:25: In file included from /wrkdirs/usr/ports/emulators/qemu-sbruno/work/qemu-bsd-user-743fbff/disas/l= ibvixl/vixl/a64/disasm-a64.h:33: In file included from /wrkdirs/usr/ports/emulators/qemu-sbruno/work/qemu-bsd-user-743fbff/disas/l= ibvixl/vixl/a64/decoder-a64.h:30: In file included from /usr/include/c++/v1/list:173: In file included from /usr/include/c++/v1/memory:616: /usr/include/c++/v1/atomic:1316:1: error: expected parameter declarator atomic_fetch_add(volatile atomic<_Tp>* __o, _Tp __op) _NOEXCEPT ^ /wrkdirs/usr/ports/emulators/qemu-sbruno/work/qemu-bsd-user-743fbff/include= /qemu/atomic.h:139:61: note: expanded from macro 'atomic_fetch_add' #define atomic_fetch_add(ptr, n) __atomic_fetch_add(ptr, n, __ATOMIC_SEQ_CS= T) ^ :16:26: note: expanded from here #define __ATOMIC_SEQ_CST 5 ^ This is because qemu's include/qemu/atomic.h defines several atomic macro n= ames which conflict with standard C++ names, e.g. atomic_fetch_add, atomic_fetch_sub, etc. Fix this (for both ports), by not defining the macr= os when __cplusplus is defined. If any future qemu C++ code needs to use these atomic macros, it will have to be fixed separately. It would be better if qemu didn't attempt to use the same identifiers as be= ing used in the C++ standard, but renaming all the instances to e.g. qemu_atomic_xxx would cause a lot of code churn, so it is probably not worth it. [1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h29m48s/logs/errors/qemu-sbruno-2.5.93.g20160428.log [2] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h29m48s/logs/errors/qemu-user-static-2.5.93.g20160428.log --=20 You are receiving this mail because: You are the assignee for the bug.=