From owner-cvs-all  Fri Aug 25  5:55: 0 2000
Delivered-To: cvs-all@freebsd.org
Received: from zibbi.mikom.csir.co.za (zibbi.mikom.csir.co.za [146.64.24.58])
	by hub.freebsd.org (Postfix) with ESMTP
	id 10B7E37B422; Fri, 25 Aug 2000 05:54:45 -0700 (PDT)
Received: (from jhay@localhost)
	by zibbi.mikom.csir.co.za (8.10.1/8.10.1) id e7PCsbW11144;
	Fri, 25 Aug 2000 14:54:37 +0200 (SAT)
From: John Hay <jhay@icomtek.co.za>
Message-Id: <200008251254.e7PCsbW11144@zibbi.mikom.csir.co.za>
Subject: Re: cvs commit: src/include unistd.h src/lib/libcrypt Makefile crypt.3         crypt.c crypt.h src/lib/libutil Makefile login_ca
In-Reply-To: <Pine.BSF.4.21.0008240839460.52828-100000@green.dyndns.org> from Brian Fundakowski Feldman at "Aug 24, 2000 08:42:36 am"
To: green@FreeBSD.org (Brian Fundakowski Feldman)
Date: Fri, 25 Aug 2000 14:54:37 +0200 (SAT)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> > >   The simple synopsis is:
> > >   edit login.conf; add a passwd_format field set to "des" or "md5"; go nuts :)
> > 
> > Has anyone been able to change passwords after this? I just get:
> > 
> > ############
> > beast:/home/jhay # passwd root
> > Changing local password for root.
> > New password:
> > Retype new password:
> > Bus error (core dumped)
> > beast:/home/jhay # 
> > ############
> 
> Try debugging it?  I have not seen this ever, nor has anyone reported it in
> testing, and I can't think of anything that would be going wrong.  Seems
> like this is maybe an NIS bug?

Ok, I did. I think you will also see the problem if you run current and
delete /etc/malloc.conf. Here is a patch to fix it. I'm not sure if it
is perfect, but passwd works and don't crash anymore. I have tried with
both des and md5 passwords. I also found out that the default is md5,
which was one question I had. :-)

John
-- 
John Hay -- John.Hay@icomtek.csir.co.za


Index: local_passwd.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/passwd/local_passwd.c,v
retrieving revision 1.25
diff -u -r1.25 local_passwd.c
--- local_passwd.c	2000/08/22 02:15:53	1.25
+++ local_passwd.c	2000/08/25 12:47:10
@@ -132,7 +132,6 @@
 		}
 		/* mixpasswordcase capability */
 		force_mix_case = login_getcapbool(lc, "mixpasswordcase", 1);
-		login_close(lc);
 	}
 #endif
 
@@ -179,6 +178,10 @@
 	to64(&salt[3], tv.tv_usec, 3);
 	to64(&salt[6], tv.tv_sec, 2);
 	salt[8] = '\0';
+#endif
+#ifdef LOGIN_CAP
+	if(lc)
+		login_close(lc);
 #endif
 	return (crypt(buf, salt));
 }


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message