Date: Wed, 7 Jun 2000 20:58:59 +0200 From: Alexander Langer <alex@big.endian.de> To: Ade Lovett <ade@FreeBSD.org> Cc: "David O'Brien" <obrien@FreeBSD.org>, ports@FreeBSD.org Subject: Re: patches/ handling Message-ID: <20000607205859.A16247@cichlids.cichlids.com> In-Reply-To: <20000607134522.A353@FreeBSD.org>; from ade@FreeBSD.org on Wed, Jun 07, 2000 at 01:45:23PM -0500 References: <20000605184259.A21736@cichlids.cichlids.com> <20000606210209.B20037@dragon.nuxi.com> <20000607090533.D44242@FreeBSD.org> <20000607091405.A55268@dragon.nuxi.com> <20000607202517.D15229@cichlids.cichlids.com> <20000607134522.A353@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Ade Lovett (ade@FreeBSD.org):
> > > I VERY much agree with you. I believe the separate arch patch path will
> > > be a maintenance nightmare.
> > I completely disagree.
> Fair enough. Can you show me an example where it would be impossible
> to have a single patch directory, given that we can patch source files
> with various #ifdef's, or case/esac on uname etc..
Not at the moment.
But I believe I'm talking against a wall or something:
**********************************************************************
* THERE IS ALREADY THE POSSIBILITY OF HAVING A SEPERATE ARCH/OPSYS *
* PATCHDIR. I ONLY CHANGE THE BEVAVIOUR OF THESE TO A WAY MORE *
* USEFUL WAY. SO IF WE REALLY REALLY REALLY REALLY HAVE TO USE THAT *
* SEPERATE PATCHDIR, WE CAN DO THAT WITH _*ADDITIONAL*_ PATCHES AND *
* NOT WITH HAVING MULTIPLE COPIES OF THE SAME PATCH IN THE SAME PORT *
**********************************************************************
I don't know why that is so hard to understand.
I agree with you guys that #ifdef is the better way in most cases.
> patches/
> patches.i386/
> patches.i386.RELENG_3/
> patches.i386.RELENG_4/
> patches.i386.CURRENT/
> patches.alpha/
> patches.alpha.RELENG_4/
> patches.alpha.CURRENT/
reduce this to patches/, patches.alpha and patches.i386, please.
$OPSYS contains the Operating system, such as FreeBSD/OpenBSD and is a
relict of old times.
> Until somebody can provide a show-stopping reason why multiple
> patch directories absolutely, positively, have to exist, then I'm
> totally against them in any way, shape, or form.
So if not, you're going to provide a patch that completely removes the
possibilty of having different patch dirs?
Remember: patches.{i386,ia64,alpha} is already possible, see above.
Alex
--
This is a FreeBSD advocacy ~/.sig.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000607205859.A16247>