From owner-cvs-all@FreeBSD.ORG Thu Jan 5 00:33:16 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB9D216A420 for ; Thu, 5 Jan 2006 00:33:16 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id 1536343D81 for ; Thu, 5 Jan 2006 00:33:06 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 43505 invoked by uid 399); 5 Jan 2006 00:33:06 -0000 Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 5 Jan 2006 00:33:06 -0000 Message-ID: <43BC6940.3030600@FreeBSD.org> Date: Wed, 04 Jan 2006 16:33:04 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20051226) MIME-Version: 1.0 To: Edwin Groothuis References: <200601042149.k04LnCjL034633@repoman.freebsd.org> In-Reply-To: <200601042149.k04LnCjL034633@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Arjan Koole , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/news/newscache Makefile pkg-plist ports/news/newscache/files newscache.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2006 00:33:17 -0000 Edwin Groothuis wrote: > edwin 2006-01-04 21:49:12 UTC > > FreeBSD ports repository > > Modified files: > news/newscache Makefile pkg-plist > Added files: > news/newscache/files newscache.sh.in > Log: > Update port: news/newscache , Added rc script > > news/newscache is lacking an rc script, so I hacked this one up > > PR: ports/91319 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91319 > Submitted by: Arjan Koole > > Revision Changes Path > 1.21 +9 -5 ports/news/newscache/Makefile > 1.1 +26 -0 ports/news/newscache/files/newscache.sh.in (new) > 1.5 +1 -0 ports/news/newscache/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/Makefile.diff?&r1=1.20&r2=1.21&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/files/newscache.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/pkg-plist.diff?&r1=1.4&r2=1.5&f=h It would be better to replace the SUB_FILES line in the Makefile with: USE_RC_SUBR= ${PORTNAME}.sh This provides several benefits in the short term. It would obviate the need for the post-install target and the pkg-plist entry, as the USE_RC_SUBR macro handles that stuff (as well as the SUB_FILES stuff) for you automatically. In the long term, we're going to add even more support for good things in the USE_RC_SUBR code, so it's a good idea to move that direction now. The script itself looks very well thought out, and takes advantage of the rc.subr mechanisms well, so congrats on that bit, and thanks for this addition. Doug -- This .signature sanitized for your protection