From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 2 16:30:15 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 530E410656BE for ; Sun, 2 Jan 2011 16:30:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7646D8FC31 for ; Sun, 2 Jan 2011 16:30:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p02GUCr5006631 for ; Sun, 2 Jan 2011 16:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p02GUCgm006630; Sun, 2 Jan 2011 16:30:12 GMT (envelope-from gnats) Resent-Date: Sun, 2 Jan 2011 16:30:12 GMT Resent-Message-Id: <201101021630.p02GUCgm006630@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1914F1065672 for ; Sun, 2 Jan 2011 16:28:49 +0000 (UTC) (envelope-from gerald@FreeBSD.org) Received: from ref8-amd64.freebsd.org (ref8-amd64.freebsd.org [IPv6:2001:4f8:fff6::5f]) by mx1.freebsd.org (Postfix) with ESMTP id 09F368FC12; Sun, 2 Jan 2011 16:28:49 +0000 (UTC) Received: from ref8-amd64.freebsd.org (localhost [127.0.0.1]) by ref8-amd64.freebsd.org (8.14.4/8.14.4) with ESMTP id p02GSmxR027793; Sun, 2 Jan 2011 16:28:48 GMT (envelope-from gerald@ref8-amd64.freebsd.org) Received: (from gerald@localhost) by ref8-amd64.freebsd.org (8.14.4/8.14.4/Submit) id p02GSmDu027792; Sun, 2 Jan 2011 16:28:48 GMT (envelope-from gerald) Message-Id: <201101021628.p02GSmDu027792@ref8-amd64.freebsd.org> Date: Sun, 2 Jan 2011 16:28:48 GMT From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/153625: Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jan 2011 16:30:15 -0000 >Number: 153625 >Category: ports >Synopsis: Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jan 02 16:30:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: >Organization: >Environment: >Description: Now that we are properly passing CPP (PR 151047) we also need to do the same for CPPFLAGS. In fact, lack of doings so has causing real bugs, cf. PR 151792 (and PR 151848) which I had to work around in the individual port. >How-To-Repeat: Try building lang/gcc44 on amd64 without the workaround that I will commit later today. >Fix: Note: the patch around MAKE_ENV appears larger than it is, we really only add CPPFLAGS and reformat things. Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.666 diff -u -r1.666 bsd.port.mk --- bsd.port.mk 29 Dec 2010 07:14:56 -0000 1.666 +++ bsd.port.mk 2 Jan 2011 16:03:24 -0000 @@ -2277,8 +2277,9 @@ MAKE_ENV+= PREFIX=${PREFIX} \ LOCALBASE=${LOCALBASE} X11BASE=${X11BASE} \ MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" \ - CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ - CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \ + CC="${CC}" CFLAGS="${CFLAGS}" \ + CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ + CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" # Add -fno-strict-aliasing to CFLAGS with optimization level -O2 or higher. @@ -3778,7 +3779,7 @@ @(cd ${CONFIGURE_WRKSRC} && \ ${SET_LATE_CONFIGURE_ARGS} \ if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ - CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \ + CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \ INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \ INSTALL_DATA="${INSTALL_DATA}" \ INSTALL_LIB="${INSTALL_LIB}" \ >Release-Note: >Audit-Trail: >Unformatted: