From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 14 08:10:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27141106566C for ; Tue, 14 Sep 2010 08:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F04E48FC0A for ; Tue, 14 Sep 2010 08:10:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o8E8A3G1044884 for ; Tue, 14 Sep 2010 08:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o8E8A37u044883; Tue, 14 Sep 2010 08:10:03 GMT (envelope-from gnats) Date: Tue, 14 Sep 2010 08:10:03 GMT Message-Id: <201009140810.o8E8A37u044883@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: jhell Cc: Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2010 08:10:04 -0000 The following reply was made to PR kern/150544; it has been noted by GNATS. From: jhell To: Pawel Jakub Dawidek Cc: Andriy Gapon , "Vladislav V. Prodan" , bug-followup@FreeBSD.org, mm@FreeBSD.org Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots Date: Tue, 14 Sep 2010 04:06:34 -0400 This is a multi-part message in MIME format. --------------030503050309090403030104 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/14/2010 03:45, Pawel Jakub Dawidek wrote: > On Tue, Sep 14, 2010 at 10:25:36AM +0300, Andriy Gapon wrote: >> on 14/09/2010 09:35 Andriy Gapon said the following: >>> >>> Maybe this happens because we don't really support .zfs/shares, but create (or >>> try to create) that directory for some reason? >>> >> >> Could you please test this patch? > > The problem was introduced AFAIK by Martin's import of v15. I think it > is handled in my v28 properly, but would need to double check. All in > all, I'd prefer if Martin could handle the problem, as I wasn't involved > in v15 and it is hard to say for me in what shape it is and what bits > are missing (Martin CCed). > >> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c >> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c >> @@ -128,7 +128,6 @@ static int zfsctl_unmount_snap >> */ >> static gfs_dirent_t zfsctl_root_entries[] = { >> { "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE }, >> - { "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE }, >> { NULL } >> }; > Andriy, That patch-up did solve it. As for what those shares directories are good for I am not sure. Do they effect the sharenfs properties at all ?. If so then I know to not apply this and to just not ls(1) or cd(1) that directory until a more proper fix has been applied. Pawel, Alright future replies if I am reading into it correctly, you will be removed from CC. Thank you for listening && looking in. Regards & Thanks again, - -- jhell,v -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQEcBAEBAgAGBQJMjy0KAAoJEJBXh4mJ2FR+PJQH/ilvW5b3jdCKDU1kLA1YcEvt bxcJF5aCNBxKzkM8HBVnTbnQ4yQLrR7EMFZxDeAnkY4heim0+A5K1+FCEtCsPb3t UJfXDAqrbhqeVctvTI/gl1fErd/3N+9WUPwgDcBwgFLFLBmBdMbb3G5LpF6Hekvz y7/s+IoyC2i2klrtDkoor6UrJk3mLKuanBJdflgANElM/N9a4GW3JhaxiYLOpS7O M2iN84OuTydfZwCxWQhD+Rc8+29RdzyAylmupOao+/t622g1Pxn0rh6TH0wJmCJx MWBTNZhTK5ZUqlxVVgrekjlkyhAWFNxzXqdD/BO2gkCKRPnadxq1P1sEmxBcMLY= =vWVW -----END PGP SIGNATURE----- --------------030503050309090403030104 Content-Type: text/plain; name="fc15fbef472b.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fc15fbef472b.txt" changeset: 222:fc15fbef472b tag: tip user: J. Hellenthal date: Tue Sep 14 03:57:52 2010 -0400 summary: PR/150544 Removed per Andriy, [SOLVED] 10/09/14 diff -r 6cc9c3ffb5d8 -r fc15fbef472b sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c Mon Sep 13 22:27:27 2010 -0400 +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c Tue Sep 14 03:57:52 2010 -0400 @@ -128,7 +128,10 @@ */ static gfs_dirent_t zfsctl_root_entries[] = { { "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE }, - { "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE }, + /* + * PR/150544 Removed per Andriy, [SOLVED] 10/09/14 + * { "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE }, + */ { NULL } }; --------------030503050309090403030104 Content-Type: application/octet-stream; name="fc15fbef472b.txt.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fc15fbef472b.txt.sig" iQEcBAABAgAGBQJMjy0KAAoJEJBXh4mJ2FR+7aoIAIzCd45jbnB67sUHVygJkao/+8S68XUz LENk87Mds7tlIu/uHhTbDdefbMGVIhI2JH4dXJb9Rr3P6yZDIO5PqAGeyGStF0No2gi/2YvQ 7rp0Gl9Wq0viXE0dVrO31lUzPBbFja8H0p8Muy+VvK1olIeRopuHWKoAtdH87aF1Ga79F7yI JKV524smqEC37ia/KF1M4RQzN0A5jHk7kNgRCQOnxglOEQCnch+rpHhYWhSo/n+2AxC1F99w 7GqR/EJTxyvZAZ+dAXdXvEz66UORM1+f7ijSFEhefc6ajo1YTojiQH3CYKEXogQXBebCdoW7 MVYUe0Mdo3SstWhdQoNfrmM= --------------030503050309090403030104--