From owner-freebsd-current Sat Feb 23 16: 3:14 2002 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 4CE9C37B400; Sat, 23 Feb 2002 16:03:09 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g1O036164477; Sat, 23 Feb 2002 16:03:06 -0800 (PST) (envelope-from dillon) Date: Sat, 23 Feb 2002 16:03:06 -0800 (PST) From: Matthew Dillon Message-Id: <200202240003.g1O036164477@apollo.backplane.com> To: Bruce Evans Cc: Terry Lambert , Alfred Perlstein , Bosko Milekic , Seigo Tanimura , , John Baldwin Subject: Re: malloc_bucket() idea (was Re: How to fix malloc.) References: <20020224105118.L30818-100000@gamplex.bde.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :My version of it does less than this. I only use it to help implement :spinlocks. You put together infrastructure to deal with pending pci interrupts? If so, then why not commit it (or at least commit a version #ifdef'd for the i386 architecture). -Matt Matthew Dillon :Index: kern_switch.c :=================================================================== :RCS file: /home/ncvs/src/sys/kern/kern_switch.c,v :retrieving revision 1.20 :diff -u -2 -r1.20 kern_switch.c :--- kern_switch.c 11 Feb 2002 20:37:51 -0000 1.20 :+++ kern_switch.c 13 Feb 2002 05:34:20 -0000 :@@ -70,14 +70,21 @@ : } : :-/* Critical sections that prevent preemption. */ :+/*- :+ * Critical section handling. :+ * XXX doesn't belong here. :+ * :+ * Entering a critical section only blocks non-fast interrupts. :+ * critical_enter() is similar to splhigh() in a 2-level spl setup under :+ * old versions of FreeBSD. :+ * :+ * Exiting from all critical sections unblocks non-fast interrupts and runs :+ * the handlers of any that were blocked. critical_exit() is similar to :+ * spl(old_level) in a 2-level spl setup under old versions of FreeBSD. :+ */ : void : critical_enter(void) : { :- struct thread *td; : :- td = curthread; :- if (td->td_critnest == 0) :- td->td_savecrit = cpu_critical_enter(); :- td->td_critnest++; :+ curthread->td_critnest++; : } : :@@ -85,12 +92,7 @@ : critical_exit(void) : { :- struct thread *td; : :- td = curthread; :- if (td->td_critnest == 1) { :- td->td_critnest = 0; :- cpu_critical_exit(td->td_savecrit); :- } else :- td->td_critnest--; :+ if (--curthread->td_critnest == 0 && (ipending | spending) != 0) :+ unpend(); : } : :Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message