From owner-svn-src-head@freebsd.org Wed Jan 11 22:33:09 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34995CAB9F5; Wed, 11 Jan 2017 22:33:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E13F71167; Wed, 11 Jan 2017 22:33:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x241.google.com with SMTP id n13so277613qtc.0; Wed, 11 Jan 2017 14:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DWh9+iV8nbm+W/nPWZDkDyBkQR9lQ9s/dKeXLNvSTSE=; b=K7bXvz0NPlh3wYkCy+GpMk678gFbUSyJwhKb7PX1edrFW1LoK6p0YWzgQlAHCvLwNf co0TJn54qb6WAUtHGrSb72RmM5jvPWL/9N41LttXElbzG4UOfK+hj2UdJy4ChE4gNLuD vO9EWdb39FlfzdBQsoqh5gDDfl+fyLKkE8zeK4CqMNIhUojWDFVsoTrLitXvVNJyOYN4 u6PfvXpQPBeqL9iS5+Fkjv/qTWT8kmXuoGgK3/rTGUh603LbAcWkhO80E35GGytdGbdm SRjnStwPC/Qm6Vsqh0dxljN1YdkbpmDVe1YJM4SNAWLgxUiPs3JZanCYCb/s43Pk+ABF SgZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DWh9+iV8nbm+W/nPWZDkDyBkQR9lQ9s/dKeXLNvSTSE=; b=eApSMy3aJlTgq80MAPwZ5jzqc/bECIDadx7JGoxeFnxs/fXwuld7+sxNHwsOzEw4Sc 53rFxeHreai2g4mr7fGUwOv2Rrv8KyfTh35/3/TCcQl4ij+h7o8VVduN7djBk2EWOkTj rf9b4EfaGu0S1tnPWief3/iY1lZu1ajmvw6XTgN5CQwpXXiPN/Eabja5Nei+7tjOBylq fUv2cAad46rxypDN3aqdv8McFga07I7zmjDFIy6kQwhf/dTc5OGy+TYKszE2DcZxtAZP BlgUKojaJ3KpNj6VsHwu5GDJmsw0QIkKX/NSKHjVp9y7WzguyncyL2LM42Zpiof7yCHl zu5w== X-Gm-Message-State: AIkVDXK7mynpa0nhx/yn0KdEmDFL0DsAAX36ZzDdu5/jRqn0Fhow+j6lubgcH9kQd0EXiBgRA5yGo3f2Ddm9Hg== X-Received: by 10.237.45.71 with SMTP id h65mr9702685qtd.244.1484173988060; Wed, 11 Jan 2017 14:33:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.83.133 with HTTP; Wed, 11 Jan 2017 14:33:07 -0800 (PST) In-Reply-To: References: <201701111847.v0BIl0Mg013954@repo.freebsd.org> <1484170956.86335.17.camel@freebsd.org> <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org> From: Ngie Cooper Date: Wed, 11 Jan 2017 14:33:07 -0800 Message-ID: Subject: Re: svn commit: r311929 - head/sys/boot/common To: Dimitry Andric Cc: Ian Lepore , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 22:33:09 -0000 On Wed, Jan 11, 2017 at 2:32 PM, Ngie Cooper wrote: > On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric wrote: > > ... > >> The line: >> >> extern int errno; >> >> expanded to: >> >> extern int (* __error()); >> >> which is a declaration of an external function pointer called __error >> (albeit with an empty parameter list). Since nobody actually refers to >> this symbol in libstand, there are no later complaints. >> >> Interestingly, reloc_elf.c does not use errno at all, so I have no idea >> why the include was originally added. > > This is why: > > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 221) #else > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 222) return (EOPNOTSUPP); > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 223) #endif Oh... sparc64's ok too. Talk about #ifdef soup. Thanks, -Ngie