From owner-svn-src-all@freebsd.org Wed Dec 16 20:30:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20F4B4C622D; Wed, 16 Dec 2020 20:30:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cx6FX50jLz3sXj; Wed, 16 Dec 2020 20:30:24 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f172.google.com with SMTP id q25so29202673oij.10; Wed, 16 Dec 2020 12:30:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LNhqUrPZLwEQ7YhUU/wXRMPq5fBO7P/CncsD5n5+Jfc=; b=Qec3/x6u9U/zopM4wjZ/NWiVU0LmRdCj3WYFvyH8iycmOxOoCQzdooqeYxQbFDexRV 1LQ5XLxvrXVz3QXrYF3TAmizJOLoP8Uy008mnVcXl6mwIcMzIsHNDsT9USuR/VtgXAdH Yzf0YuTGAyEpQ0gd2Kn4EP5qETpPeS85glCNZLQh9dJOJ90Iq9tUlBRnQgSmeO3W+98y jpaONwnhF+ZMJ1tPHDrYJzIBkJ9HxKo2o0+jEcUo7g4z0HTBAlgPkEBDoNPH4uFvPxRw mPWgdv2pGRKSAE+K9QEKtLbucuwaFdZ/gB0bg5oOEV3JYlMRqoTCL3brkdgMOFBQP+ok hR4w== X-Gm-Message-State: AOAM530Wbli9N9P66gBToV547N9+w1BKAJUn3iDF2Bui/V85JC/W+JBX eYPeuEkken0kTdK3mi2h7Zbk0qAPS0k7S6IWP1DHJeHg99A= X-Google-Smtp-Source: ABdhPJyoegBgl6OUzv1Rjja431r6fUddQzTFVWcdNrEJlZ7q5O7q93Uic5L7VyXLeszL//gxwyULCDIQCMRxY74yZU4= X-Received: by 2002:aca:af8f:: with SMTP id y137mr3035973oie.55.1608150623130; Wed, 16 Dec 2020 12:30:23 -0800 (PST) MIME-Version: 1.0 References: <202009192046.08JKkuBn080241@repo.freebsd.org> In-Reply-To: <202009192046.08JKkuBn080241@repo.freebsd.org> From: Alan Somers Date: Wed, 16 Dec 2020 13:30:12 -0700 Message-ID: Subject: Re: svn commit: r365917 - in releng/12.2: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolar... To: Allan Jude Cc: src-committers , svn-src-all , svn-src-releng@freebsd.org X-Rspamd-Queue-Id: 4Cx6FX50jLz3sXj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.167.172:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.172:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.172:from]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.172:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-releng] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 20:30:26 -0000 On Sat, Sep 19, 2020 at 2:47 PM Allan Jude wrote: > Author: allanjude > Date: Sat Sep 19 20:46:56 2020 > New Revision: 365917 > URL: https://svnweb.freebsd.org/changeset/base/365917 > > Log: > MFS r365689,r365808,r365860 > > MFOpenZFS: Introduce read/write kstats per dataset > > The following patch introduces a few statistics on reads and writes > grouped by dataset. These statistics are implemented as kstats > (backed by aggregate sums for performance) and can be retrieved by > using the dataset objset ID number. The motivation for this change is > to provide some preliminary analytics on dataset usage/performance. > > Reviewed-by: Richard Elling > Reviewed-by: Brian Behlendorf > Reviewed by: Matthew Ahrens > Signed-off-by: Serapheim Dimitropoulos > > openzfs/zfs@a448a2557ec4938ed6944c7766fe0b8e6e5f6456 > > Also contains parts of: > MFOpenZFS: Connect dataset_kstats for FreeBSD > > Example output: > kstat.zfs.mypool.dataset.objset-0x10b.nread: 150528 > kstat.zfs.mypool.dataset.objset-0x10b.reads: 48 > kstat.zfs.mypool.dataset.objset-0x10b.nwritten: 134217728 > kstat.zfs.mypool.dataset.objset-0x10b.writes: 1024 > kstat.zfs.mypool.dataset.objset-0x10b.dataset_name: mypool/datasetname > > Reviewed-by: Ryan Moeller > Reviewed by: Sean Eric Fagan > Reviewed-by: Serapheim Dimitropoulos > Reviewed-by: Brian Behlendorf > Signed-off-by: Allan Jude > > openzfs/zfs@4547fc4e071ceb1818b3a46c3035b923e06e5390 > > Approved by: re (gjb) > Relnotes: yes > Sponsored by: Klara Inc. > This sounds quite useful! I've often wished that I could see per-dataset traffic statistics. Are there any user-friendly frontends to this? Like zfs-stats, or an updated zpool iostat? -Alan