From owner-svn-src-all@freebsd.org Thu Oct 11 00:54:40 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 030B910C1A48; Thu, 11 Oct 2018 00:54:40 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB378796DE; Thu, 11 Oct 2018 00:54:39 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9D425A3F; Thu, 11 Oct 2018 00:54:39 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w9B0sddh097514; Thu, 11 Oct 2018 00:54:39 GMT (envelope-from nwhitehorn@FreeBSD.org) Received: (from nwhitehorn@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w9B0sd47097513; Thu, 11 Oct 2018 00:54:39 GMT (envelope-from nwhitehorn@FreeBSD.org) Message-Id: <201810110054.w9B0sd47097513@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: nwhitehorn set sender to nwhitehorn@FreeBSD.org using -f From: Nathan Whitehorn Date: Thu, 11 Oct 2018 00:54:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r339301 - head/share/mk X-SVN-Group: head X-SVN-Commit-Author: nwhitehorn X-SVN-Commit-Paths: head/share/mk X-SVN-Commit-Revision: 339301 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 00:54:40 -0000 Author: nwhitehorn Date: Thu Oct 11 00:54:39 2018 New Revision: 339301 URL: https://svnweb.freebsd.org/changeset/base/339301 Log: Loader GELI support, like lua loader, seems to be broken on PowerPC as well as on SPARC64 and can cause boot failures even when no encrypted disks are present. Presumably, the reasons, while unknown, are the same and most-likely are the result of some endian-unsafe code. Pending finding the actual problem, extend the blacklist entry for these parts of loader on SPARC to also cover all PowerPC platforms. Approved by: re (kib) Modified: head/share/mk/src.opts.mk Modified: head/share/mk/src.opts.mk ============================================================================== --- head/share/mk/src.opts.mk Thu Oct 11 00:26:15 2018 (r339300) +++ head/share/mk/src.opts.mk Thu Oct 11 00:54:39 2018 (r339301) @@ -353,15 +353,12 @@ BROKEN_OPTIONS+=LOADER_OFW .if ${__T:Marm*} == "" && ${__T:Mmips*} == "" && ${__T:Mpowerpc*} == "" BROKEN_OPTIONS+=LOADER_UBOOT .endif -# GELI and Lua in loader currently cause boot failures on sparc64. -# Further debugging is required. -.if ${__T} == "sparc64" +# GELI and Lua in loader currently cause boot failures on sparc64 and powerpc. +# Further debugging is required -- probably they are just broken on big +# endian systems generically (they jump to null pointers or try to read +# crazy high addresses, which is typical of endianness problems). +.if ${__T} == "sparc64" || ${__T:Mpowerpc*} BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA -.endif -# Lua in loader currently cause boot failures on powerpc. -# Further debugging is required. -.if ${__T} == "powerpc" || ${__T} == "powerpc64" -BROKEN_OPTIONS+=LOADER_LUA .endif .if ${__T:Mmips64*}